Horton

Re: Incorrect file reference in comment in procarray.c

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread View on postgr.es
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-11-13T10:20:43Z
Lists: pgsql-hackers 
On Fri, Nov 3, 2023 at 6:53 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> On Thu, Nov 2, 2023 at 10:20 PM Daniel Gustafsson <daniel@yesql.se> wrote:
> > > On 2 Nov 2023, at 13:40, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > > Attached is a small patch for that: s/heapam_visibility.c/snapmgr.c/.
> >
> > No objections to the patch, the change is correct.  However, with git grep and
> > ctags and other ways of discovery I wonder if we're not better off avoiding
> > such references to filenames which are prone to going stale (and do from time
> > to time).
>
> Agreed.  As XidInMVCCSnapshot() is an extern function, such a tool
> would allow the reader to easily find the source file that contains
> the definition of that function.

Pushed, and back-patched, like that.

Best regards,
Etsuro Fujita

Commits

  1. Remove incorrect file reference in comment.

  2. Move remaining code from tqual.[ch] to heapam.h / heapam_visibility.c.

  3. Move generic snapshot related code from tqual.h to snapmgr.h.