Horton

Thread

Commits

  1. doc: Mention archive_command failure handling on signals

  1. archive_command / pg_stat_archiver & documentation

    talk to ben <blo.talkto@gmail.com> — 2021-02-24T12:20:43Z

    Hi,

The documentation describes how a return code > 125 on the restore_command
would prevent the server from starting [1] :

"
It is important that the command return nonzero exit status on failure. The
command *will* be called requesting files that are not present in the
archive; it must return nonzero when so asked. This is not an error
condition. An exception is that if the command was terminated by a signal
(other than SIGTERM, which is used as part of a database server shutdown)
or an error by the shell (such as command not found), then recovery will
abort and the server will not start up.
"

But, I dont see such a note on the archive_command side of thing. [2]

It could happend in case the archive command is not checked beforehand  or
if the archive command becomes unavailable while PostgreSQL is running.
rsync can also return 255 in some cases (bad ssh configuration or typos).
In this case a fatal error is emitted, the archiver stops and is restarted
by the postmaster.

The view pg_stat_archiver is also not updated in this case. Is it on
purpose ? It could be problematic if someone uses it to check the archiver
process health.

Should we document this ? (I can make a patch)

regards,
Benoit

[1]
https://www.postgresql.org/docs/13/continuous-archiving.html#BACKUP-PITR-RECOVERY
[2]
https://www.postgresql.org/docs/13/continuous-archiving.html#BACKUP-ARCHIVING-WAL

  2. Re: archive_command / pg_stat_archiver & documentation

    Julien Rouhaud <rjuju123@gmail.com> — 2021-02-24T13:52:06Z

    Hi,

On Wed, Feb 24, 2021 at 8:21 PM talk to ben <blo.talkto@gmail.com> wrote:
>
> The documentation describes how a return code > 125 on the restore_command would prevent the server from starting [1] :
>
> "
> It is important that the command return nonzero exit status on failure. The command will be called requesting files that are not present in the archive; it must return nonzero when so asked. This is not an error condition. An exception is that if the command was terminated by a signal (other than SIGTERM, which is used as part of a database server shutdown) or an error by the shell (such as command not found), then recovery will abort and the server will not start up.
> "
>
> But, I dont see such a note on the archive_command side of thing. [2]
>
> It could happend in case the archive command is not checked beforehand  or if the archive command becomes unavailable while PostgreSQL is running. rsync can also return 255 in some cases (bad ssh configuration or typos). In this case a fatal error is emitted, the archiver stops and is restarted by the postmaster.
>
> The view pg_stat_archiver is also not updated in this case. Is it on purpose ? It could be problematic if someone uses it to check the archiver process health.

That's on purpose, see for instance that discussion:
https://www.postgresql.org/message-id/flat/55731BB8.1050605%40dalibo.com

> Should we document this ? (I can make a patch)

I thought that this behavior was documented, especially for the lack
of update of pg_stat_archiver.  If it's not the case then we should
definitely fix that!

  3. Re: archive_command / pg_stat_archiver & documentation

    Benoit Lobréau <benoit.lobreau@gmail.com> — 2021-02-25T11:24:57Z

    Le mer. 24 févr. 2021 à 14:52, Julien Rouhaud <rjuju123@gmail.com> a écrit :

> Hi,
>
> On Wed, Feb 24, 2021 at 8:21 PM talk to ben <blo.talkto@gmail.com> wrote:
> >
> > The documentation describes how a return code > 125 on the
> restore_command would prevent the server from starting [1] :
> >
> > "
> > It is important that the command return nonzero exit status on failure.
> The command will be called requesting files that are not present in the
> archive; it must return nonzero when so asked. This is not an error
> condition. An exception is that if the command was terminated by a signal
> (other than SIGTERM, which is used as part of a database server shutdown)
> or an error by the shell (such as command not found), then recovery will
> abort and the server will not start up.
> > "
> >
> > But, I dont see such a note on the archive_command side of thing. [2]
> >
> > It could happend in case the archive command is not checked beforehand
> or if the archive command becomes unavailable while PostgreSQL is running.
> rsync can also return 255 in some cases (bad ssh configuration or typos).
> In this case a fatal error is emitted, the archiver stops and is restarted
> by the postmaster.
> >
> > The view pg_stat_archiver is also not updated in this case. Is it on
> purpose ? It could be problematic if someone uses it to check the archiver
> process health.
>
> That's on purpose, see for instance that discussion:
> https://www.postgresql.org/message-id/flat/55731BB8.1050605%40dalibo.com
>

Thanks for pointing that out, I should have checked.


> > Should we document this ? (I can make a patch)
>
> I thought that this behavior was documented, especially for the lack
> of update of pg_stat_archiver.  If it's not the case then we should
> definitely fix that!
>

I tried to do it in the attached patch.
Building the doc worked fine on my computer.

  4. Re: archive_command / pg_stat_archiver & documentation

    Julien Rouhaud <rjuju123@gmail.com> — 2021-02-25T14:35:06Z

    On Thu, Feb 25, 2021 at 7:25 PM Benoit Lobréau <benoit.lobreau@gmail.com> wrote:
>
> Le mer. 24 févr. 2021 à 14:52, Julien Rouhaud <rjuju123@gmail.com> a écrit :
>>
>> I thought that this behavior was documented, especially for the lack
>> of update of pg_stat_archiver.  If it's not the case then we should
>> definitely fix that!
>
> I tried to do it in the attached patch.
> Building the doc worked fine on my computer.

Great, thanks!  Can you register it in the next commitfest to make
sure it won't be forgotten?

  5. Re: archive_command / pg_stat_archiver & documentation

    Benoit Lobréau <benoit.lobreau@gmail.com> — 2021-02-26T09:03:05Z

    Done here : https://commitfest.postgresql.org/32/3012/

Le jeu. 25 févr. 2021 à 15:34, Julien Rouhaud <rjuju123@gmail.com> a écrit :

> On Thu, Feb 25, 2021 at 7:25 PM Benoit Lobréau <benoit.lobreau@gmail.com>
> wrote:
> >
> > Le mer. 24 févr. 2021 à 14:52, Julien Rouhaud <rjuju123@gmail.com> a
> écrit :
> >>
> >> I thought that this behavior was documented, especially for the lack
> >> of update of pg_stat_archiver.  If it's not the case then we should
> >> definitely fix that!
> >
> > I tried to do it in the attached patch.
> > Building the doc worked fine on my computer.
>
> Great, thanks!  Can you register it in the next commitfest to make
> sure it won't be forgotten?
>

  6. Re: archive_command / pg_stat_archiver & documentation

    Michael Paquier <michael@paquier.xyz> — 2021-03-01T07:36:53Z

    On Fri, Feb 26, 2021 at 10:03:05AM +0100, Benoit Lobréau wrote:
> Done here : https://commitfest.postgresql.org/32/3012/

Documenting that properly for the archive command, as already done for
restore_command, sounds good to me.  I am not sure that there is much
point in doing a cross-reference to the archiving section for one
specific field of pg_stat_archiver.

For the second paragraph, I would recommend to move that to a
different <para> to outline this special case, leading to the
attached.

What do you think?
--
Michael

  7. Re: archive_command / pg_stat_archiver & documentation

    Julien Rouhaud <rjuju123@gmail.com> — 2021-03-01T07:55:57Z

    On Mon, Mar 1, 2021 at 3:36 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Feb 26, 2021 at 10:03:05AM +0100, Benoit Lobréau wrote:
> > Done here : https://commitfest.postgresql.org/32/3012/
>
> Documenting that properly for the archive command, as already done for
> restore_command, sounds good to me.  I am not sure that there is much
> point in doing a cross-reference to the archiving section for one
> specific field of pg_stat_archiver.

Agreed.

> For the second paragraph, I would recommend to move that to a
> different <para> to outline this special case, leading to the
> attached.

+1

> What do you think?

LGTM!

  8. Re: archive_command / pg_stat_archiver & documentation

    Benoit Lobréau <benoit.lobreau@gmail.com> — 2021-03-01T08:33:48Z

    Le lun. 1 mars 2021 à 08:36, Michael Paquier <michael@paquier.xyz> a écrit :

> On Fri, Feb 26, 2021 at 10:03:05AM +0100, Benoit Lobréau wrote:
> > Done here : https://commitfest.postgresql.org/32/3012/
>
> Documenting that properly for the archive command, as already done for
> restore_command, sounds good to me.  I am not sure that there is much
> point in doing a cross-reference to the archiving section for one
> specific field of pg_stat_archiver.
>

I wanted to add a warning that using pg_stat_archiver to monitor the good
health of the
archiver comes with a caveat in the view documentation itself. But couldn't
find a concise
way to do it. So I added a link.

If you think it's unnecessary, that's ok.


> For the second paragraph, I would recommend to move that to a
> different <para> to outline this special case, leading to the
> attached.
>

Good.

  9. Re: archive_command / pg_stat_archiver & documentation

    Julien Rouhaud <rjuju123@gmail.com> — 2021-03-01T09:17:06Z

    On Mon, Mar 1, 2021 at 4:33 PM Benoit Lobréau <benoit.lobreau@gmail.com> wrote:
>
> Le lun. 1 mars 2021 à 08:36, Michael Paquier <michael@paquier.xyz> a écrit :
>>
>> On Fri, Feb 26, 2021 at 10:03:05AM +0100, Benoit Lobréau wrote:
>> > Done here : https://commitfest.postgresql.org/32/3012/
>>
>> Documenting that properly for the archive command, as already done for
>> restore_command, sounds good to me.  I am not sure that there is much
>> point in doing a cross-reference to the archiving section for one
>> specific field of pg_stat_archiver.
>
>
> I wanted to add a warning that using pg_stat_archiver to monitor the good health of the
> archiver comes with a caveat in the view documentation itself. But couldn't find a concise
> way to do it. So I added a link.
>
> If you think it's unnecessary, that's ok.

Maybe this can be better addressed than with a link in the
documentation.  The final outcome is that it can be difficult to
monitor the archiver state in such case.  That's orthogonal to this
patch but maybe we can add a new "archiver_start" timestamptz column
in pg_stat_archiver, so monitoring tools can detect a problem if it's
too far away from pg_postmaster_start_time() for instance?

  10. Re: archive_command / pg_stat_archiver & documentation

    Benoit Lobréau <benoit.lobreau@gmail.com> — 2021-03-01T09:24:06Z

    I like the idea !

If it's not too complicated, I'd like to take a stab at it.

Le lun. 1 mars 2021 à 10:16, Julien Rouhaud <rjuju123@gmail.com> a écrit :

> On Mon, Mar 1, 2021 at 4:33 PM Benoit Lobréau <benoit.lobreau@gmail.com>
> wrote:
> >
> > Le lun. 1 mars 2021 à 08:36, Michael Paquier <michael@paquier.xyz> a
> écrit :
> >>
> >> On Fri, Feb 26, 2021 at 10:03:05AM +0100, Benoit Lobréau wrote:
> >> > Done here : https://commitfest.postgresql.org/32/3012/
> >>
> >> Documenting that properly for the archive command, as already done for
> >> restore_command, sounds good to me.  I am not sure that there is much
> >> point in doing a cross-reference to the archiving section for one
> >> specific field of pg_stat_archiver.
> >
> >
> > I wanted to add a warning that using pg_stat_archiver to monitor the
> good health of the
> > archiver comes with a caveat in the view documentation itself. But
> couldn't find a concise
> > way to do it. So I added a link.
> >
> > If you think it's unnecessary, that's ok.
>
> Maybe this can be better addressed than with a link in the
> documentation.  The final outcome is that it can be difficult to
> monitor the archiver state in such case.  That's orthogonal to this
> patch but maybe we can add a new "archiver_start" timestamptz column
> in pg_stat_archiver, so monitoring tools can detect a problem if it's
> too far away from pg_postmaster_start_time() for instance?
>

  11. Re: archive_command / pg_stat_archiver & documentation

    Julien Rouhaud <rjuju123@gmail.com> — 2021-03-01T09:33:24Z

    On Mon, Mar 1, 2021 at 5:24 PM Benoit Lobréau <benoit.lobreau@gmail.com> wrote:
>
> I like the idea !
>
> If it's not too complicated, I'd like to take a stab at it.

Great!  And it shouldn't be too complicated.  Note that unfortunately
this will likely not be included in pg14 as the last commitfest should
begin today.

  12. Re: archive_command / pg_stat_archiver & documentation

    Michael Paquier <michael@paquier.xyz> — 2021-03-02T01:29:41Z

    On Mon, Mar 01, 2021 at 05:17:06PM +0800, Julien Rouhaud wrote:
> Maybe this can be better addressed than with a link in the
> documentation.  The final outcome is that it can be difficult to
> monitor the archiver state in such case.  That's orthogonal to this
> patch but maybe we can add a new "archiver_start" timestamptz column
> in pg_stat_archiver, so monitoring tools can detect a problem if it's
> too far away from pg_postmaster_start_time() for instance?

There may be other solutions as well.  I have applied the doc patch
for now.
--
Michael

  13. Re: archive_command / pg_stat_archiver & documentation

    Julien Rouhaud <rjuju123@gmail.com> — 2021-03-02T03:10:45Z

    On Tue, Mar 2, 2021 at 9:29 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, Mar 01, 2021 at 05:17:06PM +0800, Julien Rouhaud wrote:
> > Maybe this can be better addressed than with a link in the
> > documentation.  The final outcome is that it can be difficult to
> > monitor the archiver state in such case.  That's orthogonal to this
> > patch but maybe we can add a new "archiver_start" timestamptz column
> > in pg_stat_archiver, so monitoring tools can detect a problem if it's
> > too far away from pg_postmaster_start_time() for instance?
>
> There may be other solutions as well.  I have applied the doc patch
> for now.

Thanks!

  14. Re: archive_command / pg_stat_archiver & documentation

    Benoit Lobréau <benoit.lobreau@gmail.com> — 2021-03-02T08:07:46Z

    Thanks !

Le mar. 2 mars 2021 à 04:10, Julien Rouhaud <rjuju123@gmail.com> a écrit :

> On Tue, Mar 2, 2021 at 9:29 AM Michael Paquier <michael@paquier.xyz>
> wrote:
> >
> > On Mon, Mar 01, 2021 at 05:17:06PM +0800, Julien Rouhaud wrote:
> > > Maybe this can be better addressed than with a link in the
> > > documentation.  The final outcome is that it can be difficult to
> > > monitor the archiver state in such case.  That's orthogonal to this
> > > patch but maybe we can add a new "archiver_start" timestamptz column
> > > in pg_stat_archiver, so monitoring tools can detect a problem if it's
> > > too far away from pg_postmaster_start_time() for instance?
> >
> > There may be other solutions as well.  I have applied the doc patch
> > for now.
>
> Thanks!
>

  15. Re: archive_command / pg_stat_archiver & documentation

    David Steele <david@pgmasters.net> — 2021-03-03T12:37:02Z

    On 3/1/21 8:29 PM, Michael Paquier wrote:
> On Mon, Mar 01, 2021 at 05:17:06PM +0800, Julien Rouhaud wrote:
>> Maybe this can be better addressed than with a link in the
>> documentation.  The final outcome is that it can be difficult to
>> monitor the archiver state in such case.  That's orthogonal to this
>> patch but maybe we can add a new "archiver_start" timestamptz column
>> in pg_stat_archiver, so monitoring tools can detect a problem if it's
>> too far away from pg_postmaster_start_time() for instance?
> 
> There may be other solutions as well.  I have applied the doc patch
> for now.

This was applied (except for a small part). Should we now consider this 
committed?

If not, can we get a new patch for the remaining changes?

Regards,
-- 
-David
david@pgmasters.net

  16. Re: archive_command / pg_stat_archiver & documentation

    Julien Rouhaud <rjuju123@gmail.com> — 2021-03-03T13:13:09Z

    On Wed, Mar 03, 2021 at 07:37:02AM -0500, David Steele wrote:
> On 3/1/21 8:29 PM, Michael Paquier wrote:
> > On Mon, Mar 01, 2021 at 05:17:06PM +0800, Julien Rouhaud wrote:
> > > Maybe this can be better addressed than with a link in the
> > > documentation.  The final outcome is that it can be difficult to
> > > monitor the archiver state in such case.  That's orthogonal to this
> > > patch but maybe we can add a new "archiver_start" timestamptz column
> > > in pg_stat_archiver, so monitoring tools can detect a problem if it's
> > > too far away from pg_postmaster_start_time() for instance?
> > 
> > There may be other solutions as well.  I have applied the doc patch
> > for now.
> 
> This was applied (except for a small part). Should we now consider this
> committed?
> 

I think that we should consider this as committed.

  17. Re: archive_command / pg_stat_archiver & documentation

    Michael Paquier <michael@paquier.xyz> — 2021-03-04T02:21:06Z

    On Wed, Mar 03, 2021 at 09:13:09PM +0800, Julien Rouhaud wrote:
> I think that we should consider this as committed.

It should, so done now.
--
Michael