Thread

1. Typo patch

   DaeMyung Kang <charsyam@gmail.com> — 2015-05-20T16:29:51Z

   Hi,
   
   I changed typos error. and attached patch for this.
   Thanks you.
   
   I only changed comments only
   

2. Re: Typo patch

   Heikki Linnakangas <hlinnaka@iki.fi> — 2015-05-20T16:49:29Z

   On 05/20/2015 07:29 PM, CharSyam wrote:
   > Hi,
   >
   > I changed typos error. and attached patch for this.
   > Thanks you.
   >
   > I only changed comments only
   
   Thanks, committed. Except for this one:
   
   --- src/backend/utils/sort/logtape.c
   +++ src/backend/utils/sort/logtape.c
   @@ -926,7 +926,7 @@ LogicalTapeBackspace(LogicalTapeSet *lts, int 
   tapenum, size_t size)
     /*
      * Seek to an arbitrary position in a logical tape.
      *
   - * *Only* a frozen-for-read tape can be seeked.
   + * *Only* a frozen-for-read tape can be sought.
      *
      * Return value is TRUE if seek successful, FALSE if there isn't that much
      * data in the tape (in which case there's no state change).
   
   It's true that the past tense of "seek" is "sought", but it feels a bit 
   weird to me in this context. This is a comment on a function called 
   "<blah blah>seek", and it's not clear to me that it should conjugate 
   like the normal "seek" verb.
   
   - Heikki
   
   
   
   

3. Re: Typo patch

   DaeMyung Kang <charsyam@gmail.com> — 2015-05-20T16:53:20Z

   Thanks :) You make sense.
   
   2015-05-21 1:49 GMT+09:00 Heikki Linnakangas <hlinnaka@iki.fi>:
   
   > On 05/20/2015 07:29 PM, CharSyam wrote:
   >
   >> Hi,
   >>
   >> I changed typos error. and attached patch for this.
   >> Thanks you.
   >>
   >> I only changed comments only
   >>
   >
   > Thanks, committed. Except for this one:
   >
   > --- src/backend/utils/sort/logtape.c
   > +++ src/backend/utils/sort/logtape.c
   > @@ -926,7 +926,7 @@ LogicalTapeBackspace(LogicalTapeSet *lts, int tapenum,
   > size_t size)
   >  /*
   >   * Seek to an arbitrary position in a logical tape.
   >   *
   > - * *Only* a frozen-for-read tape can be seeked.
   > + * *Only* a frozen-for-read tape can be sought.
   >   *
   >   * Return value is TRUE if seek successful, FALSE if there isn't that much
   >   * data in the tape (in which case there's no state change).
   >
   > It's true that the past tense of "seek" is "sought", but it feels a bit
   > weird to me in this context. This is a comment on a function called "<blah
   > blah>seek", and it's not clear to me that it should conjugate like the
   > normal "seek" verb.
   >
   > - Heikki
   >
   >
   

4. Re: Typo patch

   Tom Lane <tgl@sss.pgh.pa.us> — 2015-05-20T17:05:20Z

   Heikki Linnakangas <hlinnaka@iki.fi> writes:
   > Thanks, committed. Except for this one:
   
   > - * *Only* a frozen-for-read tape can be seeked.
   > + * *Only* a frozen-for-read tape can be sought.
   
   > It's true that the past tense of "seek" is "sought", but it feels a bit 
   > weird to me in this context. This is a comment on a function called 
   > "<blah blah>seek", and it's not clear to me that it should conjugate 
   > like the normal "seek" verb.
   
   I agree that "sought" is not the word to use here, but the existing
   wording isn't very good English either.  Perhaps "Seeking is only allowed
   on frozen-for-read tapes"?
   
   			regards, tom lane
   
   
   

5. Re: Typo patch

   Alvaro Herrera <alvherre@2ndquadrant.com> — 2015-05-20T17:37:47Z

   Tom Lane wrote:
   > Heikki Linnakangas <hlinnaka@iki.fi> writes:
   > > Thanks, committed. Except for this one:
   > 
   > > - * *Only* a frozen-for-read tape can be seeked.
   > > + * *Only* a frozen-for-read tape can be sought.
   > 
   > > It's true that the past tense of "seek" is "sought", but it feels a bit 
   > > weird to me in this context. This is a comment on a function called 
   > > "<blah blah>seek", and it's not clear to me that it should conjugate 
   > > like the normal "seek" verb.
   > 
   > I agree that "sought" is not the word to use here, but the existing
   > wording isn't very good English either.  Perhaps "Seeking is only allowed
   > on frozen-for-read tapes"?
   
   It would be great if you could find a solution for words such as
   "shutdowned" or "backuped".  (I don't know that we use the latter in our
   code, but I've seen it around.  The former we even have in an enum
   somewhere.)
   
   -- 
   Álvaro Herrera                http://www.2ndQuadrant.com/
   PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services