Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove unused parameter in lookup_var_attr_stats

  1. Remove unused rel parameter in lookup_var_attr_stats

    Ilia Evdokimov <ilya.evdokimov@tantorlabs.com> — 2025-01-03T14:09:02Z

    Hi hackers,

I've attached a small patch that remove unused parameter 'rel' from 
the static function lookup_var_attr_stats() in extended_stats.c

While exploring src/backend/statistics, I noticed that there are several 
other parameters which appear to be unused. However, since the 
discussion around import/export statistics [1] attribute_stats.c is 
still ongoing and many functions from other files are non-static, those 
parameters may yet prove useful. Therefore, I'm only removing the 
parameter from this static function.

Any thoughts?

[1]: 
https://www.postgresql.org/message-id/flat/CADkLM%3DcB0rF3p_FuWRTMSV0983ihTRpsH%2BOCpNyiqE7Wk0vUWA%40mail.gmail.com

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

  2. Re: Remove unused rel parameter in lookup_var_attr_stats

    Fabrízio de Royes Mello <fabriziomello@gmail.com> — 2025-01-03T15:42:01Z

    On Fri, Jan 3, 2025 at 11:09 AM Ilia Evdokimov <
ilya.evdokimov@tantorlabs.com> wrote:

> Hi hackers,
>
> I've attached a small patch that remove unused parameter 'rel' from
> the static function lookup_var_attr_stats() in extended_stats.c
>
> While exploring src/backend/statistics, I noticed that there are several
> other parameters which appear to be unused. However, since the
> discussion around import/export statistics [1] attribute_stats.c is
> still ongoing and many functions from other files are non-static, those
> parameters may yet prove useful. Therefore, I'm only removing the
> parameter from this static function.
>
>
LGTM looks like a leftover from a4d75c86.

Regards,

-- 
Fabrízio de Royes Mello

  3. Re: Remove unused rel parameter in lookup_var_attr_stats

    Ilia Evdokimov <ilya.evdokimov@tantorlabs.com> — 2025-01-06T11:26:39Z

    On 03.01.2025 18:42, Fabrízio de Royes Mello wrote:
>
> On Fri, Jan 3, 2025 at 11:09 AM Ilia Evdokimov 
> <ilya.evdokimov@tantorlabs.com> wrote:
>
>     Hi hackers,
>
>     I've attached a small patch that remove unused parameter 'rel' from
>     the static function lookup_var_attr_stats() in extended_stats.c
>
>     While exploring src/backend/statistics, I noticed that there are
>     several
>     other parameters which appear to be unused. However, since the
>     discussion around import/export statistics [1] attribute_stats.c is
>     still ongoing and many functions from other files are non-static,
>     those
>     parameters may yet prove useful. Therefore, I'm only removing the
>     parameter from this static function.
>
>
> LGTM looks like a leftover from a4d75c86.
>
> Regards,
>
> -- 
> Fabrízio de Royes Mello


True. Moreover, I checked the commit and found nothing else.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

  4. Re: Remove unused rel parameter in lookup_var_attr_stats

    Richard Guo <guofenglinux@gmail.com> — 2025-01-07T01:29:37Z

    On Fri, Jan 3, 2025 at 11:09 PM Ilia Evdokimov
<ilya.evdokimov@tantorlabs.com> wrote:
> I've attached a small patch that remove unused parameter 'rel' from
> the static function lookup_var_attr_stats() in extended_stats.c

LGTM.  It's a static function, and we can easily add this parameter
back if it's ever needed.

Thanks
Richard