Re: Remove unused rel parameter in lookup_var_attr_stats

Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>

From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>

To: fabriziomello@gmail.com

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2025-01-06T11:26:39Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove unused parameter in lookup_var_attr_stats
- 2f8b4007dbba 18.0 landed

On 03.01.2025 18:42, Fabrízio de Royes Mello wrote:
>
> On Fri, Jan 3, 2025 at 11:09 AM Ilia Evdokimov 
> <ilya.evdokimov@tantorlabs.com> wrote:
>
>     Hi hackers,
>
>     I've attached a small patch that remove unused parameter 'rel' from
>     the static function lookup_var_attr_stats() in extended_stats.c
>
>     While exploring src/backend/statistics, I noticed that there are
>     several
>     other parameters which appear to be unused. However, since the
>     discussion around import/export statistics [1] attribute_stats.c is
>     still ongoing and many functions from other files are non-static,
>     those
>     parameters may yet prove useful. Therefore, I'm only removing the
>     parameter from this static function.
>
>
> LGTM looks like a leftover from a4d75c86.
>
> Regards,
>
> -- 
> Fabrízio de Royes Mello


True. Moreover, I checked the commit and found nothing else.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.