Horton

Thread

Commits

  1. Remove unnecessary PGDATABASE settings from TAP tests

  1. Remove unneeded PGDATABASE setting from TAP tests

    Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> — 2023-12-31T01:54:08Z

    Hi,

Some of the TAP tests are explicitly setting PGDATABASE environment
variable to 'postgres', which isn't needed because the TAP test's perl
library PostgreSQL::Test::Cluster already sets it once and for all.
I've attached a patch that removes all such unneeded PGDATABASE
settings.

Thoughts?

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

  2. Re: Remove unneeded PGDATABASE setting from TAP tests

    Michael Paquier <michael@paquier.xyz> — 2023-12-31T03:06:40Z

    On Sun, Dec 31, 2023 at 07:24:08AM +0530, Bharath Rupireddy wrote:
> Some of the TAP tests are explicitly setting PGDATABASE environment
> variable to 'postgres', which isn't needed because the TAP test's perl
> library PostgreSQL::Test::Cluster already sets it once and for all.
> I've attached a patch that removes all such unneeded PGDATABASE
> settings.
> 
> Thoughts?

Hmm.  I don't see any reason to not do that as these are not really
self-documenting either.  How about 011_clusterdb_all.pl for
PGDATABASE?
--
Michael

  3. Re: Remove unneeded PGDATABASE setting from TAP tests

    Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> — 2024-01-01T08:22:10Z

    On Sun, Dec 31, 2023 at 8:36 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Sun, Dec 31, 2023 at 07:24:08AM +0530, Bharath Rupireddy wrote:
> > Some of the TAP tests are explicitly setting PGDATABASE environment
> > variable to 'postgres', which isn't needed because the TAP test's perl
> > library PostgreSQL::Test::Cluster already sets it once and for all.
> > I've attached a patch that removes all such unneeded PGDATABASE
> > settings.
> >
> > Thoughts?
>
> Hmm.  I don't see any reason to not do that as these are not really
> self-documenting either.  How about 011_clusterdb_all.pl for
> PGDATABASE?

Oh, yeah. We can remove that too, after all, PGDATABASE is being set
to postgres the default database which PostgreSQL::Test::Cluster does
set for us. I was earlier swayed by the comment atop the PGDATABASE
setting in 011_clusterdb_all.pl. Attached is v2 patch with this
change.

We perhaps can re-word and retain the comment in 011_clusterdb_all.pl,
which I think unnecessary as the code around 'alldb' if-else condition
in clusterdb.c can tell that.

-- 
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

  4. Re: Remove unneeded PGDATABASE setting from TAP tests

    Michael Paquier <michael@paquier.xyz> — 2024-01-03T01:30:05Z

    On Mon, Jan 01, 2024 at 01:52:10PM +0530, Bharath Rupireddy wrote:
> Oh, yeah. We can remove that too, after all, PGDATABASE is being set
> to postgres the default database which PostgreSQL::Test::Cluster does
> set for us. I was earlier swayed by the comment atop the PGDATABASE
> setting in 011_clusterdb_all.pl. Attached is v2 patch with this
> change.

Thanks.  Applied after keeping the comment in 011_clusterdb_all.pl,
rewording it a bit.
--
Michael