Re: Remove unneeded PGDATABASE setting from TAP tests
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-31T03:06:40Z
Lists: pgsql-hackers
On Sun, Dec 31, 2023 at 07:24:08AM +0530, Bharath Rupireddy wrote: > Some of the TAP tests are explicitly setting PGDATABASE environment > variable to 'postgres', which isn't needed because the TAP test's perl > library PostgreSQL::Test::Cluster already sets it once and for all. > I've attached a patch that removes all such unneeded PGDATABASE > settings. > > Thoughts? Hmm. I don't see any reason to not do that as these are not really self-documenting either. How about 011_clusterdb_all.pl for PGDATABASE? -- Michael
Commits
-
Remove unnecessary PGDATABASE settings from TAP tests
- 4b66d7b4e0b3 17.0 landed