Horton

Re: Comment typo in tableam.h

Ashwin Agrawal <aagrawal@pivotal.io>

View thread View on postgr.es
From: Ashwin Agrawal <aagrawal@pivotal.io>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>, Antonin Houska <ah@cybertec.at>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-07-01T19:30:04Z
Lists: pgsql-hackers

Attachments

On Fri, Jun 28, 2019 at 1:47 PM Amit Kapila <amit.kapila16@gmail.com> wrote:

> On Mon, Jun 24, 2019 at 11:26 PM Ashwin Agrawal <aagrawal@pivotal.io>
> wrote:
> >
> > On Mon, Jun 3, 2019 at 5:24 PM Ashwin Agrawal <aagrawal@pivotal.io>
> wrote:
> >>
> >> There were few more minor typos I had collected for table am, passing
> them along here.
> >>
> >> Some of the required callback functions are missing Assert checking
> (minor thing), adding them in separate patch.
> >
> >
> > Curious to know if need to register such small typo fixing and assertion
> adding patchs to commit-fest as well ?
> >
>
> Normally, such things are handled out of CF, but to avoid forgetting,
> we can register it.  However, this particular item suits more to 'Open
> Items'[1].  You can remove the objectionable part of the comment,
> other things in your patch look good to me.  If nobody else picks it
> up, I will take care of it.
>

Thank you, I thought Committer would remove the objectionable part of
comment change and commit the patch if seems fine. I don't mind changing,
just feel adds extra back and forth cycle.

Please find attached v2 of patch 1 without objectionable comment change. v1
of patch 2 attaching here just for convenience, no modifications made to it.

Commits

  1. tableam: comment improvements.

  2. Fix few typos and minor word smithing in tableam comments.

  3. Fix few typos and minor wordsmithing in tableam comments.

  4. Add missing assertions for required table am callbacks.

  5. Fix incorrect parameter name in comment