v1-0002-Add-assertions-for-required-table-am-callbacks.patch
text/x-patch
Filename: v1-0002-Add-assertions-for-required-table-am-callbacks.patch
Type: text/x-patch
Part: 1
Message:
Re: Comment typo in tableam.h
Patch
Format: format-patch
Series: patch v1-0002
Subject: Add assertions for required table am callbacks.
| File | + | − |
|---|---|---|
| src/backend/access/table/tableamapi.c | 6 | 0 |
From 4ed947590f2f61182356a7fa4bc429c679e7619f Mon Sep 17 00:00:00 2001 From: Ashwin Agrawal <aagrawal@pivotal.io> Date: Mon, 3 Jun 2019 17:07:05 -0700 Subject: [PATCH v2 2/2] Add assertions for required table am callbacks. --- src/backend/access/table/tableamapi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/backend/access/table/tableamapi.c b/src/backend/access/table/tableamapi.c index b2f58768107..98b8ea559d8 100644 --- a/src/backend/access/table/tableamapi.c +++ b/src/backend/access/table/tableamapi.c @@ -51,6 +51,7 @@ GetTableAmRoutine(Oid amhandler) Assert(routine->scan_begin != NULL); Assert(routine->scan_end != NULL); Assert(routine->scan_rescan != NULL); + Assert(routine->scan_getnextslot != NULL); Assert(routine->parallelscan_estimate != NULL); Assert(routine->parallelscan_initialize != NULL); @@ -62,8 +63,12 @@ GetTableAmRoutine(Oid amhandler) Assert(routine->index_fetch_tuple != NULL); Assert(routine->tuple_fetch_row_version != NULL); + Assert(routine->tuple_tid_valid != NULL); + Assert(routine->tuple_get_latest_tid != NULL); Assert(routine->tuple_satisfies_snapshot != NULL); + Assert(routine->compute_xid_horizon_for_tuples != NULL); + Assert(routine->tuple_insert != NULL); /* @@ -89,6 +94,7 @@ GetTableAmRoutine(Oid amhandler) Assert(routine->index_validate_scan != NULL); Assert(routine->relation_size != NULL); + Assert(routine->relation_needs_toast_table != NULL); Assert(routine->relation_estimate_size != NULL); -- 2.19.1