Horton

Thread

Commits

  1. Stabilize output of new isolation test insert-conflict-do-update-4.

  2. Remove faulty Assert in partitioned INSERT...ON CONFLICT DO UPDATE.

  1. New isolation test insert-conflict-do-update-4 outputs rows in alternative ordering

    Pavel Borisov <pashkin.elfe@gmail.com> — 2026-02-24T16:13:02Z

    Hi, hackers!

New isolation test insert-conflict-do-update-4 was added by commit 4b760a181ab2

Unlike the previous test (insert-conflict-do-update-3) it doesn't
contain an ordering clause, and when run on a table with a custom
access method, it outputs results in a reverse order.

It's a very minor issue, and the proposed fix is just adding the
missing ORDER BY clause.

Other insert-conflict-do-* isolation tests output just one row except
the mentioned insert-conflict-do-update-3 and
insert-conflict-do-update-4.

The patch is attached

Kind regards,
Pavel Borisov
Supabase

  2. Re: New isolation test insert-conflict-do-update-4 outputs rows in alternative ordering

    Pavel Borisov <pashkin.elfe@gmail.com> — 2026-02-24T18:52:00Z

    This fix should also be backported to all releases that have commit
4b760a181ab2 backported.

Pavel Borisov

On Tue, 24 Feb 2026 at 20:13, Pavel Borisov <pashkin.elfe@gmail.com> wrote:
>
> Hi, hackers!
>
> New isolation test insert-conflict-do-update-4 was added by commit 4b760a181ab2
>
> Unlike the previous test (insert-conflict-do-update-3) it doesn't
> contain an ordering clause, and when run on a table with a custom
> access method, it outputs results in a reverse order.
>
> It's a very minor issue, and the proposed fix is just adding the
> missing ORDER BY clause.
>
> Other insert-conflict-do-* isolation tests output just one row except
> the mentioned insert-conflict-do-update-3 and
> insert-conflict-do-update-4.
>
> The patch is attached
>
> Kind regards,
> Pavel Borisov
> Supabase

  3. Re: New isolation test insert-conflict-do-update-4 outputs rows in alternative ordering

    Tom Lane <tgl@sss.pgh.pa.us> — 2026-02-25T15:52:22Z

    Pavel Borisov <pashkin.elfe@gmail.com> writes:
> New isolation test insert-conflict-do-update-4 was added by commit 4b760a181ab2
> Unlike the previous test (insert-conflict-do-update-3) it doesn't
> contain an ordering clause, and when run on a table with a custom
> access method, it outputs results in a reverse order.
> It's a very minor issue, and the proposed fix is just adding the
> missing ORDER BY clause.

Right, done.

			regards, tom lane

  4. Re: New isolation test insert-conflict-do-update-4 outputs rows in alternative ordering

    Pavel Borisov <pashkin.elfe@gmail.com> — 2026-02-25T17:24:54Z

    On Wed, 25 Feb 2026 at 19:52, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Pavel Borisov <pashkin.elfe@gmail.com> writes:
> > New isolation test insert-conflict-do-update-4 was added by commit 4b760a181ab2
> > Unlike the previous test (insert-conflict-do-update-3) it doesn't
> > contain an ordering clause, and when run on a table with a custom
> > access method, it outputs results in a reverse order.
> > It's a very minor issue, and the proposed fix is just adding the
> > missing ORDER BY clause.
>
> Right, done.
>
>                         regards, tom lane
Thank you!
Regards,
Pavel Borisov