Horton

New isolation test insert-conflict-do-update-4 outputs rows in alternative ordering

Pavel Borisov <pashkin.elfe@gmail.com>

View thread View on postgr.es
From: Pavel Borisov <pashkin.elfe@gmail.com>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-02-24T16:13:02Z
Lists: pgsql-hackers

Attachments

Hi, hackers!

New isolation test insert-conflict-do-update-4 was added by commit 4b760a181ab2

Unlike the previous test (insert-conflict-do-update-3) it doesn't
contain an ordering clause, and when run on a table with a custom
access method, it outputs results in a reverse order.

It's a very minor issue, and the proposed fix is just adding the
missing ORDER BY clause.

Other insert-conflict-do-* isolation tests output just one row except
the mentioned insert-conflict-do-update-3 and
insert-conflict-do-update-4.

The patch is attached

Kind regards,
Pavel Borisov
Supabase

Commits

  1. Stabilize output of new isolation test insert-conflict-do-update-4.

  2. Remove faulty Assert in partitioned INSERT...ON CONFLICT DO UPDATE.