Horton

Thread

Commits

  1. Fix typo.

  2. Use correct variable name in publicationcmds.c.

  1. Fix couple of typos

    vignesh C <vignesh21@gmail.com> — 2025-03-17T10:13:42Z

    Hi,

While reviewing another patch, I found a couple of typos:
1) subid should have been pubid in AlterPublicationOwner and
AlterPublicationOwner_oid functions.
2) Only tuples with XIDs/MXIDs older than the the
FreezeLimit/MultiXactCutoff are frozen in the common case.
Should have been"
Only tuples with XIDs/MXIDs older than the FreezeLimit/MultiXactCutoff
are frozen in the common case.

The attached patch has the changes for the same.

Regards,
Vignesh

  2. Re: Fix couple of typos

    Amit Kapila <amit.kapila16@gmail.com> — 2025-03-17T11:15:43Z

    On Mon, Mar 17, 2025 at 3:44 PM vignesh C <vignesh21@gmail.com> wrote:
>
> While reviewing another patch, I found a couple of typos:
> 1) subid should have been pubid in AlterPublicationOwner and
> AlterPublicationOwner_oid functions.
> 2) Only tuples with XIDs/MXIDs older than the the
> FreezeLimit/MultiXactCutoff are frozen in the common case.
> Should have been"
> Only tuples with XIDs/MXIDs older than the FreezeLimit/MultiXactCutoff
> are frozen in the common case.
>
> The attached patch has the changes for the same.
>

The changes look good to me.

-- 
With Regards,
Amit Kapila.

  3. Re: Fix couple of typos

    Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> — 2025-03-17T11:27:31Z

    On Mon, Mar 17, 2025 at 4:46 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Mon, Mar 17, 2025 at 3:44 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > While reviewing another patch, I found a couple of typos:
> > 1) subid should have been pubid in AlterPublicationOwner and
> > AlterPublicationOwner_oid functions.
> > 2) Only tuples with XIDs/MXIDs older than the the
> > FreezeLimit/MultiXactCutoff are frozen in the common case.
> > Should have been"
> > Only tuples with XIDs/MXIDs older than the FreezeLimit/MultiXactCutoff
> > are frozen in the common case.
> >
> > The attached patch has the changes for the same.
> >
>
> The changes look good to me.

+1

However they look unrelated. We should split them in two commits
s/subid/pubid/ to one and s/the the/the/ to another. I also verified
that this is the only occurrence of "the the" in the code base.

-- 
Best Wishes,
Ashutosh Bapat

  4. Re: Fix couple of typos

    vignesh C <vignesh21@gmail.com> — 2025-03-18T03:19:22Z

    On Mon, 17 Mar 2025 at 16:57, Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> On Mon, Mar 17, 2025 at 4:46 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Mon, Mar 17, 2025 at 3:44 PM vignesh C <vignesh21@gmail.com> wrote:
> > >
> > > While reviewing another patch, I found a couple of typos:
> > > 1) subid should have been pubid in AlterPublicationOwner and
> > > AlterPublicationOwner_oid functions.
> > > 2) Only tuples with XIDs/MXIDs older than the the
> > > FreezeLimit/MultiXactCutoff are frozen in the common case.
> > > Should have been"
> > > Only tuples with XIDs/MXIDs older than the FreezeLimit/MultiXactCutoff
> > > are frozen in the common case.
> > >
> > > The attached patch has the changes for the same.
> > >
> >
> > The changes look good to me.
>
> +1
>
> However they look unrelated. We should split them in two commits
> s/subid/pubid/ to one and s/the the/the/ to another. I also verified
> that this is the only occurrence of "the the" in the code base.

Thanks, the updated v2 has the changes for the same.

Regards,
Vignesh

  5. Re: Fix couple of typos

    Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> — 2025-03-18T06:15:47Z

    On Tue, Mar 18, 2025 at 8:49 AM vignesh C <vignesh21@gmail.com> wrote:
>
> On Mon, 17 Mar 2025 at 16:57, Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
> >
> > On Mon, Mar 17, 2025 at 4:46 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > >
> > > On Mon, Mar 17, 2025 at 3:44 PM vignesh C <vignesh21@gmail.com> wrote:
> > > >
> > > > While reviewing another patch, I found a couple of typos:
> > > > 1) subid should have been pubid in AlterPublicationOwner and
> > > > AlterPublicationOwner_oid functions.
> > > > 2) Only tuples with XIDs/MXIDs older than the the
> > > > FreezeLimit/MultiXactCutoff are frozen in the common case.
> > > > Should have been"
> > > > Only tuples with XIDs/MXIDs older than the FreezeLimit/MultiXactCutoff
> > > > are frozen in the common case.
> > > >
> > > > The attached patch has the changes for the same.
> > > >
> > >
> > > The changes look good to me.
> >
> > +1
> >
> > However they look unrelated. We should split them in two commits
> > s/subid/pubid/ to one and s/the the/the/ to another. I also verified
> > that this is the only occurrence of "the the" in the code base.
>
> Thanks, the updated v2 has the changes for the same.

LGTM. I would mention the function name, where the typos are fixed, in
the commit message. But that can be done at the time of commit.

--
Best Wishes,
Ashutosh Bapat