Re: Fix couple of typos
vignesh C <vignesh21@gmail.com>
From: vignesh C <vignesh21@gmail.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-18T03:19:22Z
Lists: pgsql-hackers
Attachments
- v2-0001-Fix-typo.patch (text/x-patch) patch v2-0001
- v2-0002-Fix-typo.patch (text/x-patch) patch v2-0002
On Mon, 17 Mar 2025 at 16:57, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> wrote: > > On Mon, Mar 17, 2025 at 4:46 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > On Mon, Mar 17, 2025 at 3:44 PM vignesh C <vignesh21@gmail.com> wrote: > > > > > > While reviewing another patch, I found a couple of typos: > > > 1) subid should have been pubid in AlterPublicationOwner and > > > AlterPublicationOwner_oid functions. > > > 2) Only tuples with XIDs/MXIDs older than the the > > > FreezeLimit/MultiXactCutoff are frozen in the common case. > > > Should have been" > > > Only tuples with XIDs/MXIDs older than the FreezeLimit/MultiXactCutoff > > > are frozen in the common case. > > > > > > The attached patch has the changes for the same. > > > > > > > The changes look good to me. > > +1 > > However they look unrelated. We should split them in two commits > s/subid/pubid/ to one and s/the the/the/ to another. I also verified > that this is the only occurrence of "the the" in the code base. Thanks, the updated v2 has the changes for the same. Regards, Vignesh
Commits
-
Fix typo.
- 122a9af5def2 18.0 landed
-
Use correct variable name in publicationcmds.c.
- 01e27aab05f5 18.0 landed