Horton

Thread

Commits

  1. Add tests for POSITION(bytea, bytea)

  1. Patch: Cover POSITION(bytea,bytea) with tests

    Aleksander Alekseev <aleksander@timescale.com> — 2025-02-27T14:40:38Z

    Hi,

This function is currently not covered by any tests. The proposed
patch fixes this.

--
Best regards,
Aleksander Alekseev

  2. Re: Patch: Cover POSITION(bytea,bytea) with tests

    Ilia Evdokimov <ilya.evdokimov@tantorlabs.com> — 2025-03-05T13:02:02Z

    On 27.02.2025 17:40, Aleksander Alekseev wrote:
> Hi,
>
> This function is currently not covered by any tests. The proposed
> patch fixes this.
>
> --
> Best regards,
> Aleksander Alekseev


Hi,

+1. The 'POSISTION' tests include 'text', 'bits' types, but not 'bytea'.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

  3. Re: Patch: Cover POSITION(bytea,bytea) with tests

    Peter Smith <smithpb2250@gmail.com> — 2025-03-15T21:52:42Z

    +1 for this.

Some minor comments:

1. I thought the new test cases should be located earlier in the file
where there were already a couple of POSITION tests.
(see "-- E021-11 position expression")

2. Maybe one of your test cases can be identical to the example from
the docs [1].
position('\x5678'::bytea in '\x1234567890'::bytea) → 3

======
[1] https://www.postgresql.org/docs/17/functions-binarystring.html

Kind Regards,
Peter Smith.
Fujitsu Australia

  4. Re: Patch: Cover POSITION(bytea,bytea) with tests

    Aleksander Alekseev <aleksander@timescale.com> — 2025-03-17T14:14:21Z

    Hi Peter,

> Some minor comments:
>
> 1. I thought the new test cases should be located earlier in the file
> where there were already a couple of POSITION tests.
> (see "-- E021-11 position expression")
>
> 2. Maybe one of your test cases can be identical to the example from
> the docs [1].
> position('\x5678'::bytea in '\x1234567890'::bytea) → 3

Thanks.

Here is the corrected patch.

-- 
Best regards,
Aleksander Alekseev

  5. Re: Patch: Cover POSITION(bytea,bytea) with tests

    Rustam ALLAKOV <rustamallakov@gmail.com> — 2025-03-21T23:47:10Z

    The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi Aleksander, 
your patch looks good to me. 
Changing status to `Ready for Committer`

Regards,
Rustam Allakov

The new status of this patch is: Ready for Committer

  6. Re: Patch: Cover POSITION(bytea,bytea) with tests

    David Rowley <dgrowleyml@gmail.com> — 2025-03-24T06:33:48Z

    On Tue, 18 Mar 2025 at 03:14, Aleksander Alekseev
<aleksander@timescale.com> wrote:
> Here is the corrected patch.

I had a look at this and it all seems good to me.

Pushed.

David