Horton

Re: Patch: Cover POSITION(bytea,bytea) with tests

Aleksander Alekseev <aleksander@timescale.com>

View thread View on postgr.es
From: Aleksander Alekseev <aleksander@timescale.com>
To: PostgreSQL Development <pgsql-hackers@postgresql.org>
Cc: Peter Smith <smithpb2250@gmail.com>
Date: 2025-03-17T14:14:21Z
Lists: pgsql-hackers

Attachments

Hi Peter,

> Some minor comments:
>
> 1. I thought the new test cases should be located earlier in the file
> where there were already a couple of POSITION tests.
> (see "-- E021-11 position expression")
>
> 2. Maybe one of your test cases can be identical to the example from
> the docs [1].
> position('\x5678'::bytea in '\x1234567890'::bytea) → 3

Thanks.

Here is the corrected patch.

-- 
Best regards,
Aleksander Alekseev

Commits

  1. Add tests for POSITION(bytea, bytea)