Horton

Thread

Commits

  1. psql: Improve tab-completion for PREPARE.

  1. Add MERGE and VALUES statements to tab completion for PREPARE

    Haruna Miwa <miwa@sraoss.co.jp> — 2025-11-10T00:40:43Z

    Hi,

As described in the manual[1], PREPARE ... AS command supports MERGE and VALUES statements, but current psql's tab completion does not suggest them.
I created a patch that enables MERGE and VALUES to appear as tab completion suggestions.

What do you think?

[1] https://www.postgresql.org/docs/devel/sql-prepare.html

--
Haruna Miwa

  2. Re: Add MERGE and VALUES statements to tab completion for PREPARE

    Fujii Masao <masao.fujii@gmail.com> — 2025-11-10T05:15:20Z

    On Mon, Nov 10, 2025 at 9:41 AM Haruna Miwa <miwa@sraoss.co.jp> wrote:
>
> Hi,
>
> As described in the manual[1], PREPARE ... AS command supports MERGE and VALUES statements, but current psql's tab completion does not suggest them.
> I created a patch that enables MERGE and VALUES to appear as tab completion suggestions.
>
> What do you think?

+1

Should we suggest "MERGE INTO" instead of just "MERGE",
since INTO always follows MERGE?

Also, how about adding "TABLE" and "WITH" to the suggestions,
similar to the tab-completion for "COPY ("?
SELECT statement can be specified in the PREPARE command,
and it can start with SELECT, TABLE, or WITH [1].

Regards,

[1] https://www.postgresql.org/docs/devel/sql-select.html

Regards,

-- 
Fujii Masao

  3. Re: Add MERGE and VALUES statements to tab completion for PREPARE

    Haruna Miwa <miwa@sraoss.co.jp> — 2025-11-20T06:04:58Z

    > Should we suggest "MERGE INTO" instead of just "MERGE",
> since INTO always follows MERGE?
>
> Also, how about adding "TABLE" and "WITH" to the suggestions,
> similar to the tab-completion for "COPY ("?
> SELECT statement can be specified in the PREPARE command,
> and it can start with SELECT, TABLE, or WITH [1].

Agreed.
I have updated the patch.

Regards,
--
Haruna Miwa
________________________________
差出人: Fujii Masao <masao.fujii@gmail.com>
送信: 2025 年 11 月 10 日 (月曜日) 14:15
宛先: Haruna Miwa <miwa@sraoss.co.jp>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
件名: Re: Add MERGE and VALUES statements to tab completion for PREPARE

On Mon, Nov 10, 2025 at 9:41 AM Haruna Miwa <miwa@sraoss.co.jp> wrote:
>
> Hi,
>
> As described in the manual[1], PREPARE ... AS command supports MERGE and VALUES statements, but current psql's tab completion does not suggest them.
> I created a patch that enables MERGE and VALUES to appear as tab completion suggestions.
>
> What do you think?

+1

Should we suggest "MERGE INTO" instead of just "MERGE",
since INTO always follows MERGE?

Also, how about adding "TABLE" and "WITH" to the suggestions,
similar to the tab-completion for "COPY ("?
SELECT statement can be specified in the PREPARE command,
and it can start with SELECT, TABLE, or WITH [1].

Regards,

[1] https://www.postgresql.org/docs/devel/sql-select.html

Regards,

--
Fujii Masao

  4. Re: Add MERGE and VALUES statements to tab completion for PREPARE

    Fujii Masao <masao.fujii@gmail.com> — 2025-11-21T06:33:00Z

    On Thu, Nov 20, 2025 at 3:05 PM Haruna Miwa <miwa@sraoss.co.jp> wrote:
>
> > Should we suggest "MERGE INTO" instead of just "MERGE",
> > since INTO always follows MERGE?
> >
> > Also, how about adding "TABLE" and "WITH" to the suggestions,
> > similar to the tab-completion for "COPY ("?
> > SELECT statement can be specified in the PREPARE command,
> > and it can start with SELECT, TABLE, or WITH [1].
>
> Agreed.
> I have updated the patch.

Thanks for the update!

The patch looks good to me. I made one small adjustment: the updated line
was a bit long, so I added a line break. I also revised the commit message.

The updated patch is attached. I'll go ahead and commit it.

Regards,

-- 
Fujii Masao

  5. Re: Add MERGE and VALUES statements to tab completion for PREPARE

    Fujii Masao <masao.fujii@gmail.com> — 2025-11-23T14:05:50Z

    On Fri, Nov 21, 2025 at 3:33 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Thu, Nov 20, 2025 at 3:05 PM Haruna Miwa <miwa@sraoss.co.jp> wrote:
> >
> > > Should we suggest "MERGE INTO" instead of just "MERGE",
> > > since INTO always follows MERGE?
> > >
> > > Also, how about adding "TABLE" and "WITH" to the suggestions,
> > > similar to the tab-completion for "COPY ("?
> > > SELECT statement can be specified in the PREPARE command,
> > > and it can start with SELECT, TABLE, or WITH [1].
> >
> > Agreed.
> > I have updated the patch.
>
> Thanks for the update!
>
> The patch looks good to me. I made one small adjustment: the updated line
> was a bit long, so I added a line break. I also revised the commit message.
>
> The updated patch is attached. I'll go ahead and commit it.

I've pushed the patch. Thanks!

Regards,

-- 
Fujii Masao