Re: Add MERGE and VALUES statements to tab completion for PREPARE
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: Haruna Miwa <miwa@sraoss.co.jp>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2025-11-21T06:33:00Z
Lists: pgsql-hackers
Attachments
- v3-0001-psql-Improve-tab-completion-for-PREPARE.patch (application/octet-stream) patch v3-0001
On Thu, Nov 20, 2025 at 3:05 PM Haruna Miwa <miwa@sraoss.co.jp> wrote:
>
> > Should we suggest "MERGE INTO" instead of just "MERGE",
> > since INTO always follows MERGE?
> >
> > Also, how about adding "TABLE" and "WITH" to the suggestions,
> > similar to the tab-completion for "COPY ("?
> > SELECT statement can be specified in the PREPARE command,
> > and it can start with SELECT, TABLE, or WITH [1].
>
> Agreed.
> I have updated the patch.
Thanks for the update!
The patch looks good to me. I made one small adjustment: the updated line
was a bit long, so I added a line break. I also revised the commit message.
The updated patch is attached. I'll go ahead and commit it.
Regards,
--
Fujii Masao
Commits
-
psql: Improve tab-completion for PREPARE.
- 81966c5458fb 19 (unreleased) landed