Horton

Thread

Commits

  1. Suppress "variable 'pagesaving' set but not used" warning.

  1. New compiler warning from btree dedup code

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-04-06T19:59:13Z

    I just noticed that if I build without asserts on my Mac laptop
(using Apple's latest clang, 13.1.6) I get

nbtdedup.c:68:8: warning: variable 'pagesaving' set but not used [-Wunused-but-set-variable]
        Size            pagesaving = 0;
                        ^
1 warning generated.

Apparently, late-model clang can figure out that the variable
is incremented but not otherwise used.  This is enough to
shut it up, but I wonder if you have another preference:

-   Size        pagesaving = 0;
+   Size        pagesaving PG_USED_FOR_ASSERTS_ONLY = 0;

			regards, tom lane

  2. Re: New compiler warning from btree dedup code

    Peter Geoghegan <pg@bowt.ie> — 2022-04-06T20:14:04Z

    That approach seems fine. Thanks.--
Peter Geoghegan