New compiler warning from btree dedup code
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-04-06T19:59:13Z
Lists: pgsql-hackers
I just noticed that if I build without asserts on my Mac laptop
(using Apple's latest clang, 13.1.6) I get
nbtdedup.c:68:8: warning: variable 'pagesaving' set but not used [-Wunused-but-set-variable]
Size pagesaving = 0;
^
1 warning generated.
Apparently, late-model clang can figure out that the variable
is incremented but not otherwise used. This is enough to
shut it up, but I wonder if you have another preference:
- Size pagesaving = 0;
+ Size pagesaving PG_USED_FOR_ASSERTS_ONLY = 0;
regards, tom lane
Commits
-
Suppress "variable 'pagesaving' set but not used" warning.
- dbafe127bb21 15.0 landed
- a65747b1c787 14.3 landed
- 87166d25a456 13.7 landed