bugfix - plpgsql - statement counter is incremented 2x for FOR stmt
Pavel Stehule <pavel.stehule@gmail.com>
From: Pavel Stehule <pavel.stehule@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2021-02-02T17:20:46Z
Lists: pgsql-hackers
Attachments
- plpgsql-double-increment-stmtid-fix.patch (text/x-patch) patch
Hi When I fixed one plpgsql_check issue, I found another plpgsql issue. Now we have field nstatements that hold a number of plpgsql statements in function. Unfortunately I made an error when I wrote this functionality and for FOR statements, this counter is incremented 2x. Higher number than a real number is better than a lesser number, but it can be a source of problems too (inside plpgsql_check I iterate over 0 .. nstatements stmtid, and due this bug I had a problem with missing statements). Attached patch is pretty simple: Regards Pavel
Commits
-
Remove extra increment of plpgsql's statement counter for FOR loops.
- 78fab843386b 12.6 landed
- 0fe8b1f7d48e 13.2 landed
- dfcc46fe3030 14.0 landed