Horton

Thread

Commits

  1. Simplify more checks related to set-returning functions

  2. Fix inconsistencies in SRF checks of pg_config() and string_to_table()

  1. Uniforms the errors msgs at tuplestore paths

    Ranier Vilela <ranier.vf@gmail.com> — 2022-02-20T14:12:42Z

    Hi,

Like how the commit
https://github.com/postgres/postgres/commit/07daca53bfcad59618a9c6fad304e380cc9d2bc1
The are some paths that were missed:

-At jsonfuncs.c
 The errors mgs do not report about the materialize mode.
-At plperl.c
 The function plperl_return_next_internal does not check rsi appropriately.
 The error about materialize mode required, is missed.
-At pl_exec.c
 The error mgs do not report about the materialize mode
-At pltcl.c:
 The function pltcl_init_tuple_store does not check  rsi appropriately.

Patch attached.

regards,
Ranier Vilela

  2. Re: Uniforms the errors msgs at tuplestore paths

    Justin Pryzby <pryzby@telsasoft.com> — 2022-02-20T14:30:35Z

    On Sun, Feb 20, 2022 at 11:12:42AM -0300, Ranier Vilela wrote:
> Like how the commit
> https://github.com/postgres/postgres/commit/07daca53bfcad59618a9c6fad304e380cc9d2bc1
> The are some paths that were missed:

I think these are all unified by the existing tuplestore patch.
https://commitfest.postgresql.org/37/3420/

> -At jsonfuncs.c
>  The errors mgs do not report about the materialize mode.
> -At plperl.c
>  The function plperl_return_next_internal does not check rsi appropriately.
>  The error about materialize mode required, is missed.
> -At pl_exec.c
>  The error mgs do not report about the materialize mode
> -At pltcl.c:
>  The function pltcl_init_tuple_store does not check  rsi appropriately.

  3. Re: Uniforms the errors msgs at tuplestore paths

    Ranier Vilela <ranier.vf@gmail.com> — 2022-02-20T14:37:33Z

    Em dom., 20 de fev. de 2022 às 11:30, Justin Pryzby <pryzby@telsasoft.com>
escreveu:

> On Sun, Feb 20, 2022 at 11:12:42AM -0300, Ranier Vilela wrote:
> > Like how the commit
> >
> https://github.com/postgres/postgres/commit/07daca53bfcad59618a9c6fad304e380cc9d2bc1
> > The are some paths that were missed:
>
> I think these are all unified by the existing tuplestore patch.
> https://commitfest.postgresql.org/37/3420/

I can't see:
plperl.c
pl_exec.c
pttcl.c

Only jsonfuncs.c, but the error about "materialized mode" is not reported.

regards,
Ranier Vilela

  4. Re: Uniforms the errors msgs at tuplestore paths

    Michael Paquier <michael@paquier.xyz> — 2022-02-21T01:07:59Z

    On Sun, Feb 20, 2022 at 11:37:33AM -0300, Ranier Vilela wrote:
> I can't see:
> plperl.c
> pl_exec.c
> pttcl.c
> 
> Only jsonfuncs.c, but the error about "materialized mode" is not reported.

Melanie has done a nice analysis of all the code paths doing
materialization checks for her patch with SRF functions.  Though there
are parts that can be simplified to reduce the differences in check
patterns before doing the overall refactoring, I think that we'd
better keep any discussion related to this topic on the other thread
rather than splitting the effort across more threads.
--
Michael

  5. Re: Uniforms the errors msgs at tuplestore paths

    Ranier Vilela <ranier.vf@gmail.com> — 2022-02-21T01:45:37Z

    Em dom., 20 de fev. de 2022 às 22:08, Michael Paquier <michael@paquier.xyz>
escreveu:

> On Sun, Feb 20, 2022 at 11:37:33AM -0300, Ranier Vilela wrote:
> > I can't see:
> > plperl.c
> > pl_exec.c
> > pttcl.c
> >
> > Only jsonfuncs.c, but the error about "materialized mode" is not
> reported.
>
> Melanie has done a nice analysis of all the code paths doing
> materialization checks for her patch with SRF functions.  Though there
> are parts that can be simplified to reduce the differences in check
> patterns before doing the overall refactoring, I think that we'd
> better keep any discussion related to this topic on the other thread
> rather than splitting the effort across more threads.
>
Fine, I agree.

regards,
Ranier Vilela

  6. Re: Uniforms the errors msgs at tuplestore paths

    Ranier Vilela <ranier.vf@gmail.com> — 2022-02-24T11:30:02Z

    Em dom., 20 de fev. de 2022 às 22:45, Ranier Vilela <ranier.vf@gmail.com>
escreveu:

> Em dom., 20 de fev. de 2022 às 22:08, Michael Paquier <michael@paquier.xyz>
> escreveu:
>
>> On Sun, Feb 20, 2022 at 11:37:33AM -0300, Ranier Vilela wrote:
>> > I can't see:
>> > plperl.c
>> > pl_exec.c
>> > pttcl.c
>> >
>> > Only jsonfuncs.c, but the error about "materialized mode" is not
>> reported.
>>
>> Melanie has done a nice analysis of all the code paths doing
>> materialization checks for her patch with SRF functions.  Though there
>> are parts that can be simplified to reduce the differences in check
>> patterns before doing the overall refactoring, I think that we'd
>> better keep any discussion related to this topic on the other thread
>> rather than splitting the effort across more threads.
>>
> Fine, I agree.
>
Thanks for the commit Michael.

regards,
Ranier Vilela

>

  7. Re: Uniforms the errors msgs at tuplestore paths

    Michael Paquier <michael@paquier.xyz> — 2022-02-24T11:45:57Z

    On Thu, Feb 24, 2022 at 08:30:02AM -0300, Ranier Vilela wrote:
> Thanks for the commit Michael.

No problem.  For the archives, this is e77216f.
--
Michael