Re: Uniforms the errors msgs at tuplestore paths

Justin Pryzby <pryzby@telsasoft.com>

From: Justin Pryzby <pryzby@telsasoft.com>
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2022-02-20T14:30:35Z
Lists: pgsql-hackers
On Sun, Feb 20, 2022 at 11:12:42AM -0300, Ranier Vilela wrote:
> Like how the commit
> https://github.com/postgres/postgres/commit/07daca53bfcad59618a9c6fad304e380cc9d2bc1
> The are some paths that were missed:

I think these are all unified by the existing tuplestore patch.
https://commitfest.postgresql.org/37/3420/

> -At jsonfuncs.c
>  The errors mgs do not report about the materialize mode.
> -At plperl.c
>  The function plperl_return_next_internal does not check rsi appropriately.
>  The error about materialize mode required, is missed.
> -At pl_exec.c
>  The error mgs do not report about the materialize mode
> -At pltcl.c:
>  The function pltcl_init_tuple_store does not check  rsi appropriately.



Commits

  1. Simplify more checks related to set-returning functions

  2. Fix inconsistencies in SRF checks of pg_config() and string_to_table()