Horton

Thread

Commits

  1. Constify dsa_size_class_map and use a better type.

  1. Missing const in DSA.

    Mark G <markg735@gmail.com> — 2018-09-23T01:02:18Z

    While looking at some of the recent churn in DSA I noticed that
dsa_size_class_map should probably be declared const.

  2. Re: Missing const in DSA.

    Tom Lane <tgl@sss.pgh.pa.us> — 2018-09-23T21:32:17Z

    Mark G <markg735@gmail.com> writes:
> While looking at some of the recent churn in DSA I noticed that
> dsa_size_class_map should probably be declared const.

+1 ... also, given the contents of the array, "char" seems like
rather a misnomer.  I'd be happier if it were declared as uint8, say.

			regards, tom lane

  3. Re: Missing const in DSA.

    Thomas Munro <thomas.munro@enterprisedb.com> — 2018-09-24T00:27:13Z

    On Mon, Sep 24, 2018 at 9:32 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Mark G <markg735@gmail.com> writes:
> > While looking at some of the recent churn in DSA I noticed that
> > dsa_size_class_map should probably be declared const.
>
> +1 ... also, given the contents of the array, "char" seems like
> rather a misnomer.  I'd be happier if it were declared as uint8, say.

+1

-- 
Thomas Munro
http://www.enterprisedb.com

  4. Re: Missing const in DSA.

    Tom Lane <tgl@sss.pgh.pa.us> — 2018-09-24T16:17:40Z

    Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Mon, Sep 24, 2018 at 9:32 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Mark G <markg735@gmail.com> writes:
>>> While looking at some of the recent churn in DSA I noticed that
>>> dsa_size_class_map should probably be declared const.

>> +1 ... also, given the contents of the array, "char" seems like
>> rather a misnomer.  I'd be happier if it were declared as uint8, say.

> +1

Are you planning to take care of this?

			regards, tom lane

  5. Re: Missing const in DSA.

    Thomas Munro <thomas.munro@enterprisedb.com> — 2018-09-24T19:46:45Z

    On Tue, Sep 25, 2018 at 4:17 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Thomas Munro <thomas.munro@enterprisedb.com> writes:
> > On Mon, Sep 24, 2018 at 9:32 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> Mark G <markg735@gmail.com> writes:
> >>> While looking at some of the recent churn in DSA I noticed that
> >>> dsa_size_class_map should probably be declared const.
>
> >> +1 ... also, given the contents of the array, "char" seems like
> >> rather a misnomer.  I'd be happier if it were declared as uint8, say.
>
> > +1
>
> Are you planning to take care of this?

Will do.

-- 
Thomas Munro
http://www.enterprisedb.com

  6. Re: Missing const in DSA.

    Thomas Munro <thomas.munro@enterprisedb.com> — 2018-09-25T03:01:17Z

    On Tue, Sep 25, 2018 at 7:46 AM Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> On Tue, Sep 25, 2018 at 4:17 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Thomas Munro <thomas.munro@enterprisedb.com> writes:
> > > On Mon, Sep 24, 2018 at 9:32 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > >> Mark G <markg735@gmail.com> writes:
> > >>> While looking at some of the recent churn in DSA I noticed that
> > >>> dsa_size_class_map should probably be declared const.
> >
> > >> +1 ... also, given the contents of the array, "char" seems like
> > >> rather a misnomer.  I'd be happier if it were declared as uint8, say.

Pushed.  Thanks both for the code review!

-- 
Thomas Munro
http://www.enterprisedb.com