Horton

Re: Missing const in DSA.

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Mark G <markg735@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-09-25T03:01:17Z
Lists: pgsql-hackers 
On Tue, Sep 25, 2018 at 7:46 AM Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> On Tue, Sep 25, 2018 at 4:17 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Thomas Munro <thomas.munro@enterprisedb.com> writes:
> > > On Mon, Sep 24, 2018 at 9:32 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > >> Mark G <markg735@gmail.com> writes:
> > >>> While looking at some of the recent churn in DSA I noticed that
> > >>> dsa_size_class_map should probably be declared const.
> >
> > >> +1 ... also, given the contents of the array, "char" seems like
> > >> rather a misnomer.  I'd be happier if it were declared as uint8, say.

Pushed.  Thanks both for the code review!

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. Constify dsa_size_class_map and use a better type.