Horton

Thread

Commits

  1. Make error message of pageinspect more consistent for raw page inputs

  1. Inconsistent error message in bt_page_items_bytea().

    Ashutosh Sharma <ashu.coek88@gmail.com> — 2018-07-27T11:43:37Z

    Hi All,

All the pageinspect functions dealing with raw page has the error
message as "must be superuser to use raw page function" however,
that's not true for bt_page_items_bytea() which has  "must be
superuser to use pageinspect functions". This seems to me like a copy
paste error which got transferred from bt_page_items (the function
that doesn't deal with raw page).

Attached is the patch with the correct error message.

-- 
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

  2. Re: Inconsistent error message in bt_page_items_bytea().

    Michael Paquier <michael@paquier.xyz> — 2018-07-29T14:53:46Z

    On Fri, Jul 27, 2018 at 05:13:37PM +0530, Ashutosh Sharma wrote:
> All the pageinspect functions dealing with raw page has the error
> message as "must be superuser to use raw page function" however,
> that's not true for bt_page_items_bytea() which has  "must be
> superuser to use pageinspect functions". This seems to me like a copy
> paste error which got transferred from bt_page_items (the function
> that doesn't deal with raw page).

Agreed.  get_raw_page_internal() mentions "must be superuser to use raw
functions" which is inconsistent with the rest, so I fixed this second
one and pushed.  Thanks!
--
Michael