Re: Inconsistent error message in bt_page_items_bytea().

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-07-29T14:53:46Z
Lists: pgsql-hackers
On Fri, Jul 27, 2018 at 05:13:37PM +0530, Ashutosh Sharma wrote:
> All the pageinspect functions dealing with raw page has the error
> message as "must be superuser to use raw page function" however,
> that's not true for bt_page_items_bytea() which has  "must be
> superuser to use pageinspect functions". This seems to me like a copy
> paste error which got transferred from bt_page_items (the function
> that doesn't deal with raw page).

Agreed.  get_raw_page_internal() mentions "must be superuser to use raw
functions" which is inconsistent with the rest, so I fixed this second
one and pushed.  Thanks!
--
Michael

Commits

  1. Make error message of pageinspect more consistent for raw page inputs