Horton

Thread

Commits

  1. Add max_sync_workers_per_subscription to postgresql.conf.sample.

  1. max_sync_workers_per_subscription is missing in postgresql.conf

    Masahiko Sawada <sawada.mshk@gmail.com> — 2017-04-10T05:16:02Z

    Hi all,

Attached a patch for $subject.

I added this parameter into "Asynchronous Behavior" section of
"RESOURCE" section. But GUC parameter for subscriber now is written in
this section, in spite of there is "REPLICATION" section. I think that
we can coordinate these parameters to not confuse user. For example in
documentation, these parameters are described in "19.6.4. Subscribers"
section of "19.6. Replication" section. Thought?

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

  2. Re: max_sync_workers_per_subscription is missing in postgresql.conf

    Petr Jelinek <petr.jelinek@2ndquadrant.com> — 2017-04-10T12:32:55Z

    On 10/04/17 07:16, Masahiko Sawada wrote:
> Hi all,
> 
> Attached a patch for $subject.
> 
> I added this parameter into "Asynchronous Behavior" section of
> "RESOURCE" section. But GUC parameter for subscriber now is written in
> this section, in spite of there is "REPLICATION" section. I think that
> we can coordinate these parameters to not confuse user. For example in
> documentation, these parameters are described in "19.6.4. Subscribers"
> section of "19.6. Replication" section. Thought?
> 

Good catch, but it's actually taken from max_logical_replication_workers
so the patch should look more like attached IMHO.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services

  3. Re: max_sync_workers_per_subscription is missing in postgresql.conf

    Masahiko Sawada <sawada.mshk@gmail.com> — 2017-04-10T12:39:52Z

    On Mon, Apr 10, 2017 at 9:32 PM, Petr Jelinek
<petr.jelinek@2ndquadrant.com> wrote:
> On 10/04/17 07:16, Masahiko Sawada wrote:
>> Hi all,
>>
>> Attached a patch for $subject.
>>
>> I added this parameter into "Asynchronous Behavior" section of
>> "RESOURCE" section. But GUC parameter for subscriber now is written in
>> this section, in spite of there is "REPLICATION" section. I think that
>> we can coordinate these parameters to not confuse user. For example in
>> documentation, these parameters are described in "19.6.4. Subscribers"
>> section of "19.6. Replication" section. Thought?
>>
>
> Good catch, but it's actually taken from max_logical_replication_workers
> so the patch should look more like attached IMHO.
>

Thank you for the patch. The patch looks good to me.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

  4. Re: max_sync_workers_per_subscription is missing in postgresql.conf

    Fujii Masao <masao.fujii@gmail.com> — 2017-04-10T16:39:06Z

    On Mon, Apr 10, 2017 at 9:39 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> On Mon, Apr 10, 2017 at 9:32 PM, Petr Jelinek
> <petr.jelinek@2ndquadrant.com> wrote:
>> On 10/04/17 07:16, Masahiko Sawada wrote:
>>> Hi all,
>>>
>>> Attached a patch for $subject.
>>>
>>> I added this parameter into "Asynchronous Behavior" section of
>>> "RESOURCE" section. But GUC parameter for subscriber now is written in
>>> this section, in spite of there is "REPLICATION" section. I think that
>>> we can coordinate these parameters to not confuse user. For example in
>>> documentation, these parameters are described in "19.6.4. Subscribers"
>>> section of "19.6. Replication" section. Thought?

Yes, I think that we should not only add the parameter into
postgresql.conf.sample
but also

- add REPLICATION_SUBSCRIBERS into config_group
- mark max_logical_replication_workers and max_sync_workers_per_subscription
  as REPLICATION_SUBSCRIBERS parameters, in guc.c
- move those parameters into "Subscribers" section in postgresql.conf.sample

The attached patch does these.

Regards,

-- 
Fujii Masao

  5. Re: max_sync_workers_per_subscription is missing in postgresql.conf

    Masahiko Sawada <sawada.mshk@gmail.com> — 2017-04-11T07:50:40Z

    On Tue, Apr 11, 2017 at 1:39 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Mon, Apr 10, 2017 at 9:39 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> On Mon, Apr 10, 2017 at 9:32 PM, Petr Jelinek
>> <petr.jelinek@2ndquadrant.com> wrote:
>>> On 10/04/17 07:16, Masahiko Sawada wrote:
>>>> Hi all,
>>>>
>>>> Attached a patch for $subject.
>>>>
>>>> I added this parameter into "Asynchronous Behavior" section of
>>>> "RESOURCE" section. But GUC parameter for subscriber now is written in
>>>> this section, in spite of there is "REPLICATION" section. I think that
>>>> we can coordinate these parameters to not confuse user. For example in
>>>> documentation, these parameters are described in "19.6.4. Subscribers"
>>>> section of "19.6. Replication" section. Thought?
>
> Yes, I think that we should not only add the parameter into
> postgresql.conf.sample
> but also
>
> - add REPLICATION_SUBSCRIBERS into config_group
> - mark max_logical_replication_workers and max_sync_workers_per_subscription
>   as REPLICATION_SUBSCRIBERS parameters, in guc.c
> - move those parameters into "Subscribers" section in postgresql.conf.sample

+1

> The attached patch does these.

The patch looks good to me.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

  6. Re: max_sync_workers_per_subscription is missing in postgresql.conf

    Fujii Masao <masao.fujii@gmail.com> — 2017-04-11T15:12:16Z

    On Tue, Apr 11, 2017 at 4:50 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> On Tue, Apr 11, 2017 at 1:39 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> On Mon, Apr 10, 2017 at 9:39 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>> On Mon, Apr 10, 2017 at 9:32 PM, Petr Jelinek
>>> <petr.jelinek@2ndquadrant.com> wrote:
>>>> On 10/04/17 07:16, Masahiko Sawada wrote:
>>>>> Hi all,
>>>>>
>>>>> Attached a patch for $subject.
>>>>>
>>>>> I added this parameter into "Asynchronous Behavior" section of
>>>>> "RESOURCE" section. But GUC parameter for subscriber now is written in
>>>>> this section, in spite of there is "REPLICATION" section. I think that
>>>>> we can coordinate these parameters to not confuse user. For example in
>>>>> documentation, these parameters are described in "19.6.4. Subscribers"
>>>>> section of "19.6. Replication" section. Thought?
>>
>> Yes, I think that we should not only add the parameter into
>> postgresql.conf.sample
>> but also
>>
>> - add REPLICATION_SUBSCRIBERS into config_group
>> - mark max_logical_replication_workers and max_sync_workers_per_subscription
>>   as REPLICATION_SUBSCRIBERS parameters, in guc.c
>> - move those parameters into "Subscribers" section in postgresql.conf.sample
>
> +1
>
>> The attached patch does these.
>
> The patch looks good to me.

Pushed. Thanks!

Regards,

-- 
Fujii Masao