Horton

Re: max_sync_workers_per_subscription is missing in postgresql.conf

Masahiko Sawada <sawada.mshk@gmail.com>

View thread View on postgr.es
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Date: 2017-04-10T12:39:52Z
Lists: pgsql-hackers 
On Mon, Apr 10, 2017 at 9:32 PM, Petr Jelinek
<petr.jelinek@2ndquadrant.com> wrote:
> On 10/04/17 07:16, Masahiko Sawada wrote:
>> Hi all,
>>
>> Attached a patch for $subject.
>>
>> I added this parameter into "Asynchronous Behavior" section of
>> "RESOURCE" section. But GUC parameter for subscriber now is written in
>> this section, in spite of there is "REPLICATION" section. I think that
>> we can coordinate these parameters to not confuse user. For example in
>> documentation, these parameters are described in "19.6.4. Subscribers"
>> section of "19.6. Replication" section. Thought?
>>
>
> Good catch, but it's actually taken from max_logical_replication_workers
> so the patch should look more like attached IMHO.
>

Thank you for the patch. The patch looks good to me.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Commits

  1. Add max_sync_workers_per_subscription to postgresql.conf.sample.