Horton

Thread

Commits

  1. Update postgresql.conf.sample to match pg_settings classificaitons.

  1. Inconsistencies between pg_settings and postgresql.conf

    Adrian Escoms <adescoms@ongres.com> — 2017-09-13T09:51:16Z

    Hello,

We are working with postgresql.conf configuration file and we have found
some discrepancies between it and pg_settings in terms of categories and
subcategories (we have split the field category in pg_settings by '/', the
first part being 'category', the second 'subcategory')
We suggest to change the postgresql.conf.sample file with the attached diff
to resolve these inconsistencies.
We think that these changes could also be backported to previous versions.

Looking forward to your comments,


Adrián Escoms

  2. Re: Inconsistencies between pg_settings and postgresql.conf

    Adrian Escoms <adescoms@ongres.com> — 2017-09-13T15:50:27Z

    Hi,

I realized that the parameter 'shared_preload_libraries' used to belong to
category 'Resource Usage / Kernel Resources' but since postgresql version
9.4 it was changed in pg_settings to 'Client Connection Defaults / Shared
Library Preloading' but in postgresql.conf it remains unchanged.
I attach the updated postgresql.conf.sample.diff with this change.

Regards

Adrián Escoms

On Wed, Sep 13, 2017 at 11:51 AM, Adrian Escoms <adescoms@ongres.com> wrote:

> Hello,
>
> We are working with postgresql.conf configuration file and we have found
> some discrepancies between it and pg_settings in terms of categories and
> subcategories (we have split the field category in pg_settings by '/', the
> first part being 'category', the second 'subcategory')
> We suggest to change the postgresql.conf.sample file with the attached
> diff to resolve these inconsistencies.
> We think that these changes could also be backported to previous
> versions.
>
> Looking forward to your comments,
>
>
> Adrián Escoms
>

  3. Re: [HACKERS] Inconsistencies between pg_settings and postgresql.conf

    Robert Haas <robertmhaas@gmail.com> — 2017-11-15T21:30:28Z

    On Wed, Sep 13, 2017 at 11:50 AM, Adrian Escoms <adescoms@ongres.com> wrote:
> I realized that the parameter 'shared_preload_libraries' used to belong to
> category 'Resource Usage / Kernel Resources' but since postgresql version
> 9.4 it was changed in pg_settings to 'Client Connection Defaults / Shared
> Library Preloading' but in postgresql.conf it remains unchanged.
> I attach the updated postgresql.conf.sample.diff with this change.

I think this is a good idea, except I'd leave out this hunk:

@@ -105,7 +105,7 @@


 #------------------------------------------------------------------------------
-# RESOURCE USAGE (except WAL)
+# RESOURCE USAGE
 #------------------------------------------------------------------------------

 # - Memory -

I think a parenthetical gloss is a little different than different
text, and not out of place in what is after all a sample file intended
to be read by humans.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

  4. Re: [HACKERS] Inconsistencies between pg_settings and postgresql.conf

    Adrian Escoms <adescoms@ongres.com> — 2017-11-16T11:08:35Z

    Hi,

It makes sense, so I attach the new diff without these lines.
Thank you,

Regards

Adrián Escoms

On Wed, Nov 15, 2017 at 10:30 PM, Robert Haas <robertmhaas@gmail.com> wrote:

> On Wed, Sep 13, 2017 at 11:50 AM, Adrian Escoms <adescoms@ongres.com>
> wrote:
> > I realized that the parameter 'shared_preload_libraries' used to belong
> to
> > category 'Resource Usage / Kernel Resources' but since postgresql version
> > 9.4 it was changed in pg_settings to 'Client Connection Defaults / Shared
> > Library Preloading' but in postgresql.conf it remains unchanged.
> > I attach the updated postgresql.conf.sample.diff with this change.
>
> I think this is a good idea, except I'd leave out this hunk:
>
> @@ -105,7 +105,7 @@
>
>
>  #-----------------------------------------------------------
> -------------------
> -# RESOURCE USAGE (except WAL)
> +# RESOURCE USAGE
>  #-----------------------------------------------------------
> -------------------
>
>  # - Memory -
>
> I think a parenthetical gloss is a little different than different
> text, and not out of place in what is after all a sample file intended
> to be read by humans.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

  5. Re: [HACKERS] Inconsistencies between pg_settings and postgresql.conf

    Robert Haas <robertmhaas@gmail.com> — 2017-11-16T17:57:49Z

    On Thu, Nov 16, 2017 at 6:08 AM, Adrian Escoms <adescoms@ongres.com> wrote:
> It makes sense, so I attach the new diff without these lines.

Thanks.  Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company