Re: [HACKERS] Inconsistencies between pg_settings and postgresql.conf

Adrian Escoms <adescoms@ongres.com>

From: Adrian Escoms <adescoms@ongres.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-11-16T11:08:35Z
Lists: pgsql-hackers

Attachments

Hi,

It makes sense, so I attach the new diff without these lines.
Thank you,

Regards

Adrián Escoms

On Wed, Nov 15, 2017 at 10:30 PM, Robert Haas <robertmhaas@gmail.com> wrote:

> On Wed, Sep 13, 2017 at 11:50 AM, Adrian Escoms <adescoms@ongres.com>
> wrote:
> > I realized that the parameter 'shared_preload_libraries' used to belong
> to
> > category 'Resource Usage / Kernel Resources' but since postgresql version
> > 9.4 it was changed in pg_settings to 'Client Connection Defaults / Shared
> > Library Preloading' but in postgresql.conf it remains unchanged.
> > I attach the updated postgresql.conf.sample.diff with this change.
>
> I think this is a good idea, except I'd leave out this hunk:
>
> @@ -105,7 +105,7 @@
>
>
>  #-----------------------------------------------------------
> -------------------
> -# RESOURCE USAGE (except WAL)
> +# RESOURCE USAGE
>  #-----------------------------------------------------------
> -------------------
>
>  # - Memory -
>
> I think a parenthetical gloss is a little different than different
> text, and not out of place in what is after all a sample file intended
> to be read by humans.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Commits

  1. Update postgresql.conf.sample to match pg_settings classificaitons.