Re: Reduce TupleHashEntryData struct size by half

David Rowley <dgrowleyml@gmail.com>

From: David Rowley <dgrowleyml@gmail.com>

To: Jeff Davis <pgsql@j-davis.com>

Cc: Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers@postgresql.org

Date: 2025-01-14T19:38:27Z

Lists: pgsql-hackers

On Wed, 15 Jan 2025 at 07:47, Jeff Davis <pgsql@j-davis.com> wrote:
>
> On Tue, 2025-01-14 at 22:01 +1300, David Rowley wrote:
> > The trick would be to ensure ExecClearTuple() still works.
>
> I'm confused by this. The comment over copy_minimal_slot says:

I must have confused TupleTableSlotOps.copy_minimal_tuple with
get_minimal_tuple. Admittedly, I didn't look at the code and was
working from memory, which must be faulty.  Sounds like this makes
things easier. Good.

David

Commits

Comment fixups from 626df47ad9.
- a0c7b765372d 18.0 landed
Remove 'additional' pointer from TupleHashEntryData.
- 626df47ad9db 18.0 cited
Add ExecCopySlotMinimalTupleExtra().
- a0942f441ed6 18.0 landed
Create accessor functions for TupleHashEntry.
- 4d143509cbfa 18.0 landed
TupleHashTable: store additional data along with tuple.
- e0ece2a981ee 18.0 landed
ExecInitAgg: update aggstate->numaggs and ->numtrans earlier.
- 3f482940dbcb 18.0 landed
nodeSetOp.c: missing additionalsize for BuildTupleHashTable().
- 32ddfaffd149 18.0 landed
Remove unused TupleHashTableData->entrysize.
- 8a96faedc408 18.0 landed
Add missing typedefs.list entry for AggStatePerGroupData.
- 834c9e807cf1 18.0 landed