Horton

Thread

Commits

  1. Fix comment in pg_proc.c

  1. Correct comment in ProcedureCreate() for pgstat_create_function() call.

    Amul Sul <sulamul@gmail.com> — 2022-05-13T04:50:52Z

    Hi,

PFA, attached patch to $SUBJECT.

-- 
Regards,
Amul Sul
EDB: http://www.enterprisedb.com

  2. Re: Correct comment in ProcedureCreate() for pgstat_create_function() call.

    Amul Sul <sulamul@gmail.com> — 2022-05-13T04:52:57Z

    Sorry, hit the send button too early :|

Attached here !!

On Fri, May 13, 2022 at 10:20 AM Amul Sul <sulamul@gmail.com> wrote:
>
> Hi,
>
> PFA, attached patch to $SUBJECT.
>
> --
> Regards,
> Amul Sul
> EDB: http://www.enterprisedb.com

  3. Re: Correct comment in ProcedureCreate() for pgstat_create_function() call.

    Michael Paquier <michael@paquier.xyz> — 2022-05-13T07:09:00Z

    On Fri, May 13, 2022 at 10:22:57AM +0530, Amul Sul wrote:
> Sorry, hit the send button too early :|

-   /* ensure that stats are dropped if transaction commits */
+   /* ensure that stats are dropped if transaction aborts */
    if (!is_update)
            pgstat_create_function(retval);

As of what pgstat_create_function() does to create the stats of a new
function in a transactional way, it looks like you are right.  Will
fix if there are no objections.
--
Michael

  4. Re: Correct comment in ProcedureCreate() for pgstat_create_function() call.

    Michael Paquier <michael@paquier.xyz> — 2022-05-13T23:29:04Z

    On Fri, May 13, 2022 at 04:09:00PM +0900, Michael Paquier wrote:
> As of what pgstat_create_function() does to create the stats of a new
> function in a transactional way, it looks like you are right.  Will
> fix if there are no objections.

And done with fcab82a.  Thanks, Amul.
--
Michael