Horton

Re: Correct comment in ProcedureCreate() for pgstat_create_function() call.

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Amul Sul <sulamul@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2022-05-13T07:09:00Z
Lists: pgsql-hackers 
On Fri, May 13, 2022 at 10:22:57AM +0530, Amul Sul wrote:
> Sorry, hit the send button too early :|

-   /* ensure that stats are dropped if transaction commits */
+   /* ensure that stats are dropped if transaction aborts */
    if (!is_update)
            pgstat_create_function(retval);

As of what pgstat_create_function() does to create the stats of a new
function in a transactional way, it looks like you are right.  Will
fix if there are no objections.
--
Michael

Commits

  1. Fix comment in pg_proc.c