Horton

Thread

Commits

  1. Don't unset MAKEFLAGS in non-GNU Makefile.

  2. Prevent passing down MAKELEVEL/MAKEFLAGS from non-GNU make to GNU make.

  1. MAKEFLAGS in non-GNU Makefile

    Thomas Munro <thomas.munro@gmail.com> — 2019-06-24T08:21:46Z

    Hi,

In commit a76200de we added a line to unset MAKELEVEL to fix a problem
with our temp-install logic.  I don't think it was a great idea to
clear MAKEFLAGS at the same time, because now when you type "make -s
-j8" on a non-GNU system it ignores you and is loud and slow.
Admittedly there is something slightly weird about passing flags to
both makes, but in the case of widely understood flags like those
ones, it works fine.

-- 
Thomas Munro
https://enterprisedb.com

  2. Re: MAKEFLAGS in non-GNU Makefile

    Tom Lane <tgl@sss.pgh.pa.us> — 2019-06-24T14:29:13Z

    Thomas Munro <thomas.munro@gmail.com> writes:
> In commit a76200de we added a line to unset MAKELEVEL to fix a problem
> with our temp-install logic.  I don't think it was a great idea to
> clear MAKEFLAGS at the same time, because now when you type "make -s
> -j8" on a non-GNU system it ignores you and is loud and slow.

Feel free to undo that.  I was concerned about possible incompatibilities
in the makeflags, but if typical cases like this one seem to work, let's
allow it.

			regards, tom lane