Horton

Re: MAKEFLAGS in non-GNU Makefile

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-06-24T14:29:13Z
Lists: pgsql-hackers 
Thomas Munro <thomas.munro@gmail.com> writes:
> In commit a76200de we added a line to unset MAKELEVEL to fix a problem
> with our temp-install logic.  I don't think it was a great idea to
> clear MAKEFLAGS at the same time, because now when you type "make -s
> -j8" on a non-GNU system it ignores you and is loud and slow.

Feel free to undo that.  I was concerned about possible incompatibilities
in the makeflags, but if typical cases like this one seem to work, let's
allow it.

			regards, tom lane

Commits

  1. Don't unset MAKEFLAGS in non-GNU Makefile.

  2. Prevent passing down MAKELEVEL/MAKEFLAGS from non-GNU make to GNU make.