Horton

Thread

Commits

  1. Use correct type for catalog_xmin

  2. Fix excessive logging in idle slotsync worker.

  1. Use correct type for catalog_xmin

    Imran Zaheer <imran.zhir@gmail.com> — 2026-06-05T10:03:01Z

    Hi

In commit 85c17f6, the variable old_catalog_xmin is using the type
XLogRecPtr, even though data.catalog_xmin is a TransactionId.

Attached patch fixes this by using TransactionId instead

Thanks
Imran Zaheer

  2. Re: Use correct type for catalog_xmin

    Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> — 2026-06-05T11:52:35Z

    On Fri, Jun 5, 2026 at 3:33 PM Imran Zaheer <imran.zhir@gmail.com> wrote:
>
> Hi
>
> In commit 85c17f6, the variable old_catalog_xmin is using the type
> XLogRecPtr, even though data.catalog_xmin is a TransactionId.
>
> Attached patch fixes this by using TransactionId instead

Yes. Looks like a copy-pasto in 85c17f612af7b9c47a9828805686f0dd2433cdf1.

Patch LGTM.

-- 
Best Wishes,
Ashutosh Bapat

  3. Re: Use correct type for catalog_xmin

    Fujii Masao <masao.fujii@gmail.com> — 2026-06-08T05:34:43Z

    On Fri, Jun 5, 2026 at 8:52 PM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> On Fri, Jun 5, 2026 at 3:33 PM Imran Zaheer <imran.zhir@gmail.com> wrote:
> >
> > Hi
> >
> > In commit 85c17f6, the variable old_catalog_xmin is using the type
> > XLogRecPtr, even though data.catalog_xmin is a TransactionId.
> >
> > Attached patch fixes this by using TransactionId instead
>
> Yes. Looks like a copy-pasto in 85c17f612af7b9c47a9828805686f0dd2433cdf1.
>
> Patch LGTM.

LGTM.

This does not seem to cause any functional issue even without the fix,
since the variable is only used for an equality check. However, the type
is clearly incorrect, so I think it's better to backpatch it through v17.

Regards,

-- 
Fujii Masao

  4. Re: Use correct type for catalog_xmin

    Amit Kapila <amit.kapila16@gmail.com> — 2026-06-08T06:07:30Z

    On Mon, Jun 8, 2026 at 11:05 AM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Fri, Jun 5, 2026 at 8:52 PM Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
> >
> > On Fri, Jun 5, 2026 at 3:33 PM Imran Zaheer <imran.zhir@gmail.com> wrote:
> > >
> > > Hi
> > >
> > > In commit 85c17f6, the variable old_catalog_xmin is using the type
> > > XLogRecPtr, even though data.catalog_xmin is a TransactionId.
> > >
> > > Attached patch fixes this by using TransactionId instead
> >
> > Yes. Looks like a copy-pasto in 85c17f612af7b9c47a9828805686f0dd2433cdf1.
> >
> > Patch LGTM.
>
> LGTM.
>
> This does not seem to cause any functional issue even without the fix,
> since the variable is only used for an equality check. However, the type
> is clearly incorrect, so I think it's better to backpatch it through v17.
>

+1.

-- 
With Regards,
Amit Kapila.

  5. Re: Use correct type for catalog_xmin

    Fujii Masao <masao.fujii@gmail.com> — 2026-06-08T23:21:43Z

    On Mon, Jun 8, 2026 at 3:07 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > This does not seem to cause any functional issue even without the fix,
> > since the variable is only used for an equality check. However, the type
> > is clearly incorrect, so I think it's better to backpatch it through v17.
> >
>
> +1.

Yeah! I've pushed the patch and backpatched it to v17. Thanks!

Regards,

-- 
Fujii Masao