Re: Use correct type for catalog_xmin

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

To: Imran Zaheer <imran.zhir@gmail.com>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2026-06-05T11:52:35Z

Lists: pgsql-hackers

On Fri, Jun 5, 2026 at 3:33 PM Imran Zaheer <imran.zhir@gmail.com> wrote:
>
> Hi
>
> In commit 85c17f6, the variable old_catalog_xmin is using the type
> XLogRecPtr, even though data.catalog_xmin is a TransactionId.
>
> Attached patch fixes this by using TransactionId instead

Yes. Looks like a copy-pasto in 85c17f612af7b9c47a9828805686f0dd2433cdf1.

Patch LGTM.

-- 
Best Wishes,
Ashutosh Bapat

Commits

Use correct type for catalog_xmin
- 9db452c23550 17 (unreleased) landed
- beb09e911735 18 (unreleased) landed
- bd4bd30ce6a7 19 (unreleased) landed
Fix excessive logging in idle slotsync worker.
- 85c17f612af7 19 (unreleased) cited