Re: an outdated comment for hash_seq_init.

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-04-25T15:00:16Z
Lists: pgsql-hackers
On Mon, Apr 24, 2017 at 3:55 AM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> While I looked into dynahash.c, I found that the following
> sentense became outdated by 5dfc198. The commit removed the only
> usage of hash_freeze().
>
>> * NOTE: it is possible to use hash_seq_init/hash_seq_search without any
>> * worry about hash_seq_term cleanup, if the hashtable is first locked against
>> * further insertions by calling hash_freeze.  This is used by nodeAgg.c,
>> * wherein it is inconvenient to track whether a scan is still open, and
>> * there's no possibility of further insertions after readout has begun.
>
> The attached patch removes the sentence begins with "This is used
> by..".

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Commits

  1. Adjust outdated comment.