Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Refactor COPY FROM to use format callback functions.

  2. Fix missing space in EXPLAIN ANALYZE output.

  3. Adjust pg_dump tag for relation stats.

  4. Allow EXPLAIN to indicate fractional rows.

  1. Space missing from EXPLAIN output

    Thom Brown <thom@linux.com> — 2025-02-28T16:37:20Z

    Hi,

Commit ddb17e387aa introduced fractional row counts, but the rejigging
has introduced a formatting issue:

Worker 0:  actual time=34.779..34.780rows=0 loops=1
  Buffers: shared hit=1200
Worker 1:  actual time=39.737..39.738rows=0 loops=1
  Buffers: shared hit=1084

A space is missing between the time values and the "rows" label.

Patch attached to fix.

Regards

Thom

  2. Re: Space missing from EXPLAIN output

    Fabrízio de Royes Mello <fabriziomello@gmail.com> — 2025-02-28T16:54:13Z

    On Fri, Feb 28, 2025 at 1:38 PM Thom Brown <thom@linux.com> wrote:

> Hi,
>
> Commit ddb17e387aa introduced fractional row counts, but the rejigging
> has introduced a formatting issue:
>
> Worker 0:  actual time=34.779..34.780rows=0 loops=1
>   Buffers: shared hit=1200
> Worker 1:  actual time=39.737..39.738rows=0 loops=1
>   Buffers: shared hit=1084
>
> A space is missing between the time values and the "rows" label.
>
>
Are you sure your main is updated? The current main
is 424ededc580b03e1bcf8aff18a735e519c80061f.

Because your patch is not applying:
main on  main [$]
➜ git apply /tmp/fix_explain_analyze_spacing.diff
error: patch failed: src/backend/commands/explain.c:2075
error: src/backend/commands/explain.c: patch does not apply

On the current main your change should be on line 2041 and not 2075
according to your patch.

Regards,

-- 
Fabrízio de Royes Mello

  3. Re: Space missing from EXPLAIN output

    Thom Brown <thom@linux.com> — 2025-02-28T17:11:44Z

    On Fri, 28 Feb 2025 at 16:54, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
>
>
> On Fri, Feb 28, 2025 at 1:38 PM Thom Brown <thom@linux.com> wrote:
>>
>> Hi,
>>
>> Commit ddb17e387aa introduced fractional row counts, but the rejigging
>> has introduced a formatting issue:
>>
>> Worker 0:  actual time=34.779..34.780rows=0 loops=1
>>   Buffers: shared hit=1200
>> Worker 1:  actual time=39.737..39.738rows=0 loops=1
>>   Buffers: shared hit=1084
>>
>> A space is missing between the time values and the "rows" label.
>>
>
> Are you sure your main is updated? The current main is 424ededc580b03e1bcf8aff18a735e519c80061f.
>
> Because your patch is not applying:
> main on  main [$]
> ➜ git apply /tmp/fix_explain_analyze_spacing.diff
> error: patch failed: src/backend/commands/explain.c:2075
> error: src/backend/commands/explain.c: patch does not apply
>
> On the current main your change should be on line 2041 and not 2075 according to your patch.

Erk, yes, my main wasn't up-to-date. Thanks for pointing that out.

Rebased and attached.

Thom

  4. Re: Space missing from EXPLAIN output

    Robert Haas <robertmhaas@gmail.com> — 2025-02-28T18:08:09Z

    On Fri, Feb 28, 2025 at 12:12 PM Thom Brown <thom@linux.com> wrote:
> Rebased and attached.

Thanks, committed. Sorry for the mistake and thanks for the patch.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

  5. Re: Space missing from EXPLAIN output

    Ilia Evdokimov <ilya.evdokimov@tantorlabs.com> — 2025-02-28T19:48:39Z

    On 28.02.2025 21:08, Robert Haas wrote:
> On Fri, Feb 28, 2025 at 12:12 PM Thom Brown <thom@linux.com> wrote:
>> Rebased and attached.
> Thanks, committed. Sorry for the mistake and thanks for the patch.
>

Hi hackers,

First of all, sorry about the space issue - that was my oversight.

I also just noticed another documentation mistake on my part regarding 
the fractional rows display [0]. In one place, I forgot to append '.00'. 
I overlooked this because, in my local branch, this change was already 
committed as part of my local previous patches, so it didn't show up in 
the diff.

Apologies for the oversight! I've attached a fix for this on last commit 
7717f63.

[0]: 
https://www.postgresql.org/message-id/40663fc5-edac-4b45-a2aa-a76976700ed9%40tantorlabs.com

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

  6. Re: Space missing from EXPLAIN output

    Fabrízio de Royes Mello <fabriziomello@gmail.com> — 2025-02-28T21:05:59Z

    On Fri, Feb 28, 2025 at 4:48 PM Ilia Evdokimov <
ilya.evdokimov@tantorlabs.com> wrote:

>
> On 28.02.2025 21:08, Robert Haas wrote:
> > On Fri, Feb 28, 2025 at 12:12 PM Thom Brown <thom@linux.com> wrote:
> >> Rebased and attached.
> > Thanks, committed. Sorry for the mistake and thanks for the patch.
> >
>
> Hi hackers,
>
> First of all, sorry about the space issue - that was my oversight.
>
> I also just noticed another documentation mistake on my part regarding
> the fractional rows display [0]. In one place, I forgot to append '.00'.
> I overlooked this because, in my local branch, this change was already
> committed as part of my local previous patches, so it didn't show up in
> the diff.
>
> Apologies for the oversight! I've attached a fix for this on last commit
> 7717f63.
>
> [0]:
>
> https://www.postgresql.org/message-id/40663fc5-edac-4b45-a2aa-a76976700ed9%40tantorlabs.com
>
>
LGTM

-- 
Fabrízio de Royes Mello

  7. Re: Space missing from EXPLAIN output

    Robert Haas <robertmhaas@gmail.com> — 2025-03-07T14:12:57Z

    On Fri, Feb 28, 2025 at 4:06 PM Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
> On Fri, Feb 28, 2025 at 4:48 PM Ilia Evdokimov <ilya.evdokimov@tantorlabs.com> wrote:
>> Apologies for the oversight! I've attached a fix for this on last commit
>> 7717f63.
> LGTM

Committed.

-- 
Robert Haas
EDB: http://www.enterprisedb.com