Re: Space missing from EXPLAIN output

Fabrízio de Royes Mello <fabriziomello@gmail.com>

From: Fabrízio de Royes Mello <fabriziomello@gmail.com>

To: Thom Brown <thom@linux.com>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2025-02-28T16:54:13Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Refactor COPY FROM to use format callback functions.
- 7717f6300693 18.0 cited
Fix missing space in EXPLAIN ANALYZE output.
- 51d3e279c3e1 18.0 landed
Adjust pg_dump tag for relation stats.
- 424ededc580b 18.0 cited
Allow EXPLAIN to indicate fractional rows.
- ddb17e387aa2 18.0 cited

On Fri, Feb 28, 2025 at 1:38 PM Thom Brown <thom@linux.com> wrote:

> Hi,
>
> Commit ddb17e387aa introduced fractional row counts, but the rejigging
> has introduced a formatting issue:
>
> Worker 0:  actual time=34.779..34.780rows=0 loops=1
>   Buffers: shared hit=1200
> Worker 1:  actual time=39.737..39.738rows=0 loops=1
>   Buffers: shared hit=1084
>
> A space is missing between the time values and the "rows" label.
>
>
Are you sure your main is updated? The current main
is 424ededc580b03e1bcf8aff18a735e519c80061f.

Because your patch is not applying:
main on  main [$]
➜ git apply /tmp/fix_explain_analyze_spacing.diff
error: patch failed: src/backend/commands/explain.c:2075
error: src/backend/commands/explain.c: patch does not apply

On the current main your change should be on line 2041 and not 2075
according to your patch.

Regards,

-- 
Fabrízio de Royes Mello