Horton

Thread

Commits

  1. doc: Mention that toast_tuple_target affects also column marked as Main.

  1. Add a description to the documentation that toast_tuple_target affects "Main"

    Shinya Okano <btokanosn@oss.nttdata.com> — 2020-10-09T08:43:55Z

    Hi,

Regarding the toast_tuple_target parameter of CREATE TABLE, the 
documentation says that it only affects External or Extended, but it 
actually affects the compression of Main as well.

The attached patch modifies the document to match the actual behavior.

Regards,

-- 
Shinya Okano

  2. Re: Add a description to the documentation that toast_tuple_target affects "Main"

    Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com> — 2020-10-13T01:40:59Z

    Hi,

On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano <btokanosn@oss.nttdata.com> wrote:
>
> Hi,
>
> Regarding the toast_tuple_target parameter of CREATE TABLE, the
> documentation says that it only affects External or Extended, but it
> actually affects the compression of Main as well.
>
> The attached patch modifies the document to match the actual behavior.
+1

Best regards,

-- 
Tatsuhito Kasahara
kasahara.tatsuhito _at_ gmail.com

  3. Re: Add a description to the documentation that toast_tuple_target affects "Main"

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2020-10-13T16:30:06Z

    
On 2020/10/13 10:40, Kasahara Tatsuhito wrote:
> Hi,
> 
> On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano <btokanosn@oss.nttdata.com> wrote:
>>
>> Hi,
>>
>> Regarding the toast_tuple_target parameter of CREATE TABLE, the
>> documentation says that it only affects External or Extended, but it
>> actually affects the compression of Main as well.
>>
>> The attached patch modifies the document to match the actual behavior.
> +1

+1

+      we try to compress long column values or to move into TOAST tables, and

"we try to compress and/or move long column values into TOAST tables, and" is better?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  4. Re: Add a description to the documentation that toast_tuple_target affects "Main"

    Shinya Okano <btokanosn@oss.nttdata.com> — 2020-10-14T07:21:37Z

    On 2020-10-14 01:30, Fujii Masao wrote:
> On 2020/10/13 10:40, Kasahara Tatsuhito wrote:
>> On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano 
>> <btokanosn@oss.nttdata.com> wrote:
>>> Regarding the toast_tuple_target parameter of CREATE TABLE, the
>>> documentation says that it only affects External or Extended, but it
>>> actually affects the compression of Main as well.
>>> 
>>> The attached patch modifies the document to match the actual 
>>> behavior.
>> +1
> 
> +1
> 
> +      we try to compress long column values or to move into TOAST 
> tables, and
> 
> "we try to compress and/or move long column values into TOAST tables,
> and" is better?

Thank you everyone for reviews.
I attached the new version of the patch.

Regards,

-- 
Shinya Okano

  5. Re: Add a description to the documentation that toast_tuple_target affects "Main"

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2020-10-15T02:12:10Z

    
On 2020/10/14 16:21, Shinya Okano wrote:
> On 2020-10-14 01:30, Fujii Masao wrote:
>> On 2020/10/13 10:40, Kasahara Tatsuhito wrote:
>>> On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano <btokanosn@oss.nttdata.com> wrote:
>>>> Regarding the toast_tuple_target parameter of CREATE TABLE, the
>>>> documentation says that it only affects External or Extended, but it
>>>> actually affects the compression of Main as well.
>>>>
>>>> The attached patch modifies the document to match the actual behavior.
>>> +1
>>
>> +1
>>
>> +      we try to compress long column values or to move into TOAST tables, and
>>
>> "we try to compress and/or move long column values into TOAST tables,
>> and" is better?
> 
> Thank you everyone for reviews.
> I attached the new version of the patch.

Thanks for updating the patch! Pushed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION