Re: Add a description to the documentation that toast_tuple_target affects "Main"

Shinya Okano <btokanosn@oss.nttdata.com>

From: Shinya Okano <btokanosn@oss.nttdata.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>, Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-10-14T07:21:37Z
Lists: pgsql-hackers

Attachments

On 2020-10-14 01:30, Fujii Masao wrote:
> On 2020/10/13 10:40, Kasahara Tatsuhito wrote:
>> On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano 
>> <btokanosn@oss.nttdata.com> wrote:
>>> Regarding the toast_tuple_target parameter of CREATE TABLE, the
>>> documentation says that it only affects External or Extended, but it
>>> actually affects the compression of Main as well.
>>> 
>>> The attached patch modifies the document to match the actual 
>>> behavior.
>> +1
> 
> +1
> 
> +      we try to compress long column values or to move into TOAST 
> tables, and
> 
> "we try to compress and/or move long column values into TOAST tables,
> and" is better?

Thank you everyone for reviews.
I attached the new version of the patch.

Regards,

-- 
Shinya Okano

Commits

  1. doc: Mention that toast_tuple_target affects also column marked as Main.