Horton

Thread

Commits

  1. Use explicit_bzero() when clearing sslpassword in libpq

  2. Use explicit_bzero

  1. explicit_bzero for sslpassword

    Daniel Gustafsson <daniel@yesql.se> — 2020-05-19T12:33:40Z

    Since commit 74a308cf5221f we use explicit_bzero on pgpass and connhost
password in libpq, but not sslpassword which seems an oversight.  The attached
performs an explicit_bzero before freeing like the pattern for other password
variables.

cheers ./daniel

  2. Re: explicit_bzero for sslpassword

    Michael Paquier <michael@paquier.xyz> — 2020-05-20T05:56:50Z

    On Tue, May 19, 2020 at 02:33:40PM +0200, Daniel Gustafsson wrote:
> Since commit 74a308cf5221f we use explicit_bzero on pgpass and connhost
> password in libpq, but not sslpassword which seems an oversight.  The attached
> performs an explicit_bzero before freeing like the pattern for other password
> variables.

Good catch, let's fix that.  I would like to apply your suggested fix,
but let's see first if others have any comments.
--
Michael

  3. Re: explicit_bzero for sslpassword

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2020-05-20T08:06:55Z

    On 2020-05-20 07:56, Michael Paquier wrote:
> On Tue, May 19, 2020 at 02:33:40PM +0200, Daniel Gustafsson wrote:
>> Since commit 74a308cf5221f we use explicit_bzero on pgpass and connhost
>> password in libpq, but not sslpassword which seems an oversight.  The attached
>> performs an explicit_bzero before freeing like the pattern for other password
>> variables.
> 
> Good catch, let's fix that.  I would like to apply your suggested fix,
> but let's see first if others have any comments.

Looks correct to me.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  4. Re: explicit_bzero for sslpassword

    Michael Paquier <michael@paquier.xyz> — 2020-05-21T07:29:18Z

    On Wed, May 20, 2020 at 10:06:55AM +0200, Peter Eisentraut wrote:
> Looks correct to me.

Thanks for confirming, Peter.  Got this one applied.
--
Michael