Horton

Re: explicit_bzero for sslpassword

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>, Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-05-20T08:06:55Z
Lists: pgsql-hackers 
On 2020-05-20 07:56, Michael Paquier wrote:
> On Tue, May 19, 2020 at 02:33:40PM +0200, Daniel Gustafsson wrote:
>> Since commit 74a308cf5221f we use explicit_bzero on pgpass and connhost
>> password in libpq, but not sslpassword which seems an oversight.  The attached
>> performs an explicit_bzero before freeing like the pattern for other password
>> variables.
> 
> Good catch, let's fix that.  I would like to apply your suggested fix,
> but let's see first if others have any comments.

Looks correct to me.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Use explicit_bzero() when clearing sslpassword in libpq

  2. Use explicit_bzero