Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove MsgType type

  1. Remove MsgType type

    Peter Eisentraut <peter@eisentraut.org> — 2025-12-22T08:46:13Z

    Presumably, the C type MsgType was meant to hold the protocol message 
type in the pre-version-3 era, but this was never fully developed even 
then, and the name is pretty confusing nowadays.  It has only one 
vestigial use for cancel requests that we can get rid of.  Since a 
cancel request is indicated by a special protocol version number, we can 
use the ProtocolVersion type, which MsgType was based on.  (If this is 
also found confusing, we could also use uint32 directly.)

  2. Re: Remove MsgType type

    Chao Li <li.evan.chao@gmail.com> — 2025-12-22T09:06:41Z

    
> On Dec 22, 2025, at 16:46, Peter Eisentraut <peter@eisentraut.org> wrote:
> 
> Presumably, the C type MsgType was meant to hold the protocol message type in the pre-version-3 era, but this was never fully developed even then, and the name is pretty confusing nowadays.  It has only one vestigial use for cancel requests that we can get rid of.  Since a cancel request is indicated by a special protocol version number, we can use the ProtocolVersion type, which MsgType was based on.  (If this is also found confusing, we could also use uint32 directly.)
> <0001-Remove-MsgType-type.patch>

LGTM. I searched over the source tree, MsgType had only a single usage before the patch, so it makes sense to remove it.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

  3. Re: Remove MsgType type

    Peter Eisentraut <peter@eisentraut.org> — 2025-12-27T22:47:30Z

    On 22.12.25 10:06, Chao Li wrote:
>> On Dec 22, 2025, at 16:46, Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> Presumably, the C type MsgType was meant to hold the protocol message type in the pre-version-3 era, but this was never fully developed even then, and the name is pretty confusing nowadays.  It has only one vestigial use for cancel requests that we can get rid of.  Since a cancel request is indicated by a special protocol version number, we can use the ProtocolVersion type, which MsgType was based on.  (If this is also found confusing, we could also use uint32 directly.)
>> <0001-Remove-MsgType-type.patch>
> 
> LGTM. I searched over the source tree, MsgType had only a single usage before the patch, so it makes sense to remove it.

committed, thanks