Re: Remove MsgType type

Chao Li <li.evan.chao@gmail.com>

From: Chao Li <li.evan.chao@gmail.com>

To: Peter Eisentraut <peter@eisentraut.org>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2025-12-22T09:06:41Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove MsgType type
- b63443718a4a 19 (unreleased) landed


> On Dec 22, 2025, at 16:46, Peter Eisentraut <peter@eisentraut.org> wrote:
> 
> Presumably, the C type MsgType was meant to hold the protocol message type in the pre-version-3 era, but this was never fully developed even then, and the name is pretty confusing nowadays.  It has only one vestigial use for cancel requests that we can get rid of.  Since a cancel request is indicated by a special protocol version number, we can use the ProtocolVersion type, which MsgType was based on.  (If this is also found confusing, we could also use uint32 directly.)
> <0001-Remove-MsgType-type.patch>

LGTM. I searched over the source tree, MsgType had only a single usage before the patch, so it makes sense to remove it.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/