Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. doc: Add documentation for pg_database.datlocprovider column

  1. PG15 beta1 fix pg_database view document

    Shinoda, Noriyoshi <noriyoshi.shinoda@hpe.com> — 2022-05-23T02:00:18Z

    Hi hackers,
    Thanks to all the developers. The attached patch updates the manual for the pg_database catalog.
    The current pg_database view definition is missing the datlocprovider column. The attached patch adds this column info.
    https://www.postgresql.org/docs/15/catalog-pg-database.html
    
    Regards,
    Noriyoshi Shinoda
    
  2. Re: PG15 beta1 fix pg_database view document

    Michael Paquier <michael@paquier.xyz> — 2022-05-23T04:25:15Z

    On Mon, May 23, 2022 at 02:00:18AM +0000, Shinoda, Noriyoshi (PN Japan FSIP) wrote:
    > Thanks to all the developers. The attached patch updates the manual
    > for the pg_database catalog.
    > The current pg_database view definition is missing the
    > datlocprovider column. The attached patch adds this column info. 
    > https://www.postgresql.org/docs/15/catalog-pg-database.html
    
    Indeed.  I have checked the rest of the catalog headers for any
    inconsistencies with the docs and what you have noticed here is the
    only one.
    
    +       <structfield>datlocprovider</structfield> <type>char</type>
    +      </para>
    +      <para>
    +       Provider of the collation for this database:
    <literal>c</literal> = libc, <literal>i</literal> = icu
    +      </para></entry>
    
    ICU needs to be upper-case if you are referring to the library name.
    Here, my guess is that you are referring to the value that can be
    passed down to the command?  You could use lower-case terms like on
    the CREATE COLLATION page, but I would put these within a <literal>
    markup.  Anyway, this formulation is incorrect.
    --
    Michael
    
  3. Re: PG15 beta1 fix pg_database view document

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2022-05-23T08:37:38Z

    On 23.05.22 06:25, Michael Paquier wrote:
    > Indeed.  I have checked the rest of the catalog headers for any
    > inconsistencies with the docs and what you have noticed here is the
    > only one.
    
    Committed.  Thanks for checking.
    
    > +       <structfield>datlocprovider</structfield> <type>char</type>
    > +      </para>
    > +      <para>
    > +       Provider of the collation for this database:
    > <literal>c</literal> = libc, <literal>i</literal> = icu
    > +      </para></entry>
    > 
    > ICU needs to be upper-case if you are referring to the library name.
    > Here, my guess is that you are referring to the value that can be
    > passed down to the command?  You could use lower-case terms like on
    > the CREATE COLLATION page, but I would put these within a <literal>
    > markup.  Anyway, this formulation is incorrect.
    
    This is presumably copied from pg_collation.collprovider, which uses the 
    same markup.  If we want to improve it, they should be changed together.