Re: PG15 beta1 fix pg_database view document

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>, "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2022-05-23T08:37:38Z
Lists: pgsql-hackers
On 23.05.22 06:25, Michael Paquier wrote:
> Indeed.  I have checked the rest of the catalog headers for any
> inconsistencies with the docs and what you have noticed here is the
> only one.

Committed.  Thanks for checking.

> +       <structfield>datlocprovider</structfield> <type>char</type>
> +      </para>
> +      <para>
> +       Provider of the collation for this database:
> <literal>c</literal> = libc, <literal>i</literal> = icu
> +      </para></entry>
> 
> ICU needs to be upper-case if you are referring to the library name.
> Here, my guess is that you are referring to the value that can be
> passed down to the command?  You could use lower-case terms like on
> the CREATE COLLATION page, but I would put these within a <literal>
> markup.  Anyway, this formulation is incorrect.

This is presumably copied from pg_collation.collprovider, which uses the 
same markup.  If we want to improve it, they should be changed together.



Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. doc: Add documentation for pg_database.datlocprovider column