Thread

1. Re: Improve pgindent's formatting named fields in struct literals and varidic functions

   Tom Lane <tgl@sss.pgh.pa.us> — 2026-05-05T18:10:10Z

   Andreas Karlsson <andreas@proxel.se> writes:
   > Rebased patch on top of HEAD.
   
   I've reviewed and tested this, and attached is the version I have
   staged for commit.  Differences from yours:
   
   * Bump pg_bsd_indent's version number to ensure people use the
   right version.
   
   * Include the change in tests/declarations.0.stdout in the main
   patch.  Without this, "make check-world" fails after that patch.
   We don't want to create land-mines like that for future git
   bisect runs.
   
   v6-0002 shows the effects the patch would currently have.
   This isn't a commit, since the effects could very well still
   change before this gets committed.
   
   			regards, tom lane
   
   

2. Re: Improve pgindent's formatting named fields in struct literals and varidic functions

   Andreas Karlsson <andreas@proxel.se> — 2026-05-05T18:14:53Z

   On 5/5/26 8:10 PM, Tom Lane wrote:
   > I've reviewed and tested this, and attached is the version I have
   > staged for commit.  Differences from yours:
   
   Thanks!
   
   > * Bump pg_bsd_indent's version number to ensure people use the
   > right version.
   
   Sounds good.
   
   > * Include the change in tests/declarations.0.stdout in the main
   > patch.  Without this, "make check-world" fails after that patch.
   > We don't want to create land-mines like that for future git
   > bisect runs.
   
   Thanks for fixing that!
   
   -- 
   Andreas Karlsson
   Percona