Re: Improve pgindent's formatting named fields in struct literals and varidic functions

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Andreas Karlsson <andreas@proxel.se>

Cc: Álvaro Herrera <alvherre@kurilemu.de>, Jelte Fennema-Nio <postgres@jeltef.nl>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2026-05-05T18:10:10Z

Lists: pgsql-hackers

Attachments

v6-0001-Make-pg_bsd_indent-add-a-space-between-comma-and-.patch (text/x-diff) patch v6-0001
v6-0002-effects.patch.nocfbot (text/x-diff) patch v6-0002

Andreas Karlsson <andreas@proxel.se> writes:
> Rebased patch on top of HEAD.

I've reviewed and tested this, and attached is the version I have
staged for commit.  Differences from yours:

* Bump pg_bsd_indent's version number to ensure people use the
right version.

* Include the change in tests/declarations.0.stdout in the main
patch.  Without this, "make check-world" fails after that patch.
We don't want to create land-mines like that for future git
bisect runs.

v6-0002 shows the effects the patch would currently have.
This isn't a commit, since the effects could very well still
change before this gets committed.

			regards, tom lane